Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2217783002: DevTools: use view locations in the elements and sources sidebars. (Closed)

Created:
4 years, 4 months ago by pfeldman
Modified:
4 years, 4 months ago
Reviewers:
dgozman
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, caseq+blink_chromium.org, aboxhall, extensions-reviews_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, lushnikov+blink_chromium.org, yuzo+watch_chromium.org, pfeldman+blink_chromium.org, nektarios, dmazzoni, apavlov+blink_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, devtools-reviews_chromium.org, blink-reviews, je_julie, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: use view locations in the elements and sources sidebars. BUG=634145 Committed: https://crrev.com/c58d14b485ad001da13adaced10dcdfeb6983c7a Cr-Commit-Position: refs/heads/master@{#410260}

Patch Set 1 #

Total comments: 14

Patch Set 2 : review comments #

Patch Set 3 : wip #

Patch Set 4 : t checkout master# This is a combination of 2 commits. #

Patch Set 5 : ready for review #

Total comments: 8

Patch Set 6 : for landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+803 lines, -644 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/inspector/debugger-test.js View 1 2 3 4 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/elements-test.js View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/elements/event-listeners-framework-with-service-worker.html View 1 2 3 4 3 chunks +5 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/elements/event-listeners-framework-with-service-worker-expected.txt View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js View 1 2 3 4 1 chunk +1 line, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/animation/animation-empty-web-animations.html View 1 1 chunk +3 lines, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/animation/animation-timeline.html View 1 1 chunk +4 lines, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/animation/animation-web-anim-negative-start-time.html View 1 1 chunk +4 lines, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/accessibility/accessibility-pane-test.js View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/extensions/extensions-events.html View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/extensions/extensions-sidebar.html View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/reveal-objects.html View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/error-in-watch-expressions.html View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/watch-expressions-panel-switch.html View 1 2 3 4 1 chunk +7 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/watch-expressions-preserve-expansion.html View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/tabbed-pane-closeable-persistence.html View 1 1 chunk +23 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/devtools/devtools.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilitySidebarView.js View 3 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/audits/AuditResultView.js View 1 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/audits/AuditsPanel.js View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/components/BreakpointsSidebarPaneBase.js View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js View 1 4 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js View 1 2 3 4 5 5 chunks +24 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/ElementsSidebarPane.js View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/extensions/ExtensionPanel.js View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/main/Main.js View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/network/RequestPreviewView.js View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotView.js View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/profiler/ProfileView.js View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/profiler/ProfilesPanel.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/resources/ApplicationCacheItemsView.js View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/resources/CookieItemsView.js View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/resources/DOMStorageItemsView.js View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/resources/DatabaseTableView.js View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/resources/IndexedDBViews.js View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/resources/ResourcesPanel.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkerCacheViews.js View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/settings/SettingsScreen.js View 1 2 3 4 5 3 chunks +7 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/source_frame/FontView.js View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/source_frame/ImageView.js View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/source_frame/SourceFrame.js View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/CallStackSidebarPane.js View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/EventListenerBreakpointsSidebarPane.js View 1 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/JavaScriptBreakpointsSidebarPane.js View 1 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/ObjectEventListenersSidebarPane.js View 4 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/ScopeChainSidebarPane.js View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js View 1 2 3 4 5 6 chunks +27 lines, -34 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/SourcesView.js View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/ThreadsSidebarPane.js View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/WatchExpressionsSidebarPane.js View 1 2 3 5 chunks +10 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/XHRBreakpointsSidebarPane.js View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/module.json View 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/InspectorView.js View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/TabbedPane.js View 1 2 1 chunk +0 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/ThrottledView.js View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/View.js View 1 2 3 4 5 11 chunks +548 lines, -112 lines 0 comments Download
D third_party/WebKit/Source/devtools/front_end/ui/ViewContainers.js View 1 2 1 chunk +0 lines, -225 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/Widget.js View 1 2 1 chunk +0 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/module.json View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/viewContainers.css View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/scripts/compile_frontend.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
pfeldman
Still needs work, but ready for conceptual review.
4 years, 4 months ago (2016-08-04 22:54:32 UTC) #2
dgozman
https://codereview.chromium.org/2217783002/diff/1/third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js File third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js (right): https://codereview.chromium.org/2217783002/diff/1/third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js#newcode104 third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js:104: this.sidebarPaneView.showView(WebInspector.UIString("Styles")); Instance! https://codereview.chromium.org/2217783002/diff/1/third_party/WebKit/Source/devtools/front_end/profiler/ProfilesPanel.js File third_party/WebKit/Source/devtools/front_end/profiler/ProfilesPanel.js (right): https://codereview.chromium.org/2217783002/diff/1/third_party/WebKit/Source/devtools/front_end/profiler/ProfilesPanel.js#newcode820 third_party/WebKit/Source/devtools/front_end/profiler/ProfilesPanel.js:820: this._profileViewToolbar.appendToolbarItem(toolbarItems[i]); ...
4 years, 4 months ago (2016-08-05 01:32:09 UTC) #3
pfeldman
Fixing all the rest. https://codereview.chromium.org/2217783002/diff/1/third_party/WebKit/Source/devtools/front_end/ui/View.js File third_party/WebKit/Source/devtools/front_end/ui/View.js (right): https://codereview.chromium.org/2217783002/diff/1/third_party/WebKit/Source/devtools/front_end/ui/View.js#newcode663 third_party/WebKit/Source/devtools/front_end/ui/View.js:663: if (!container) { On 2016/08/05 ...
4 years, 4 months ago (2016-08-05 04:42:16 UTC) #4
dgozman
lgtm https://codereview.chromium.org/2217783002/diff/80001/third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js File third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js (right): https://codereview.chromium.org/2217783002/diff/80001/third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js#newcode953 third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js:953: this.sidebarPanes.metrics.setParentViewForReveal(computedPane); nit: move next to others under TODO ...
4 years, 4 months ago (2016-08-06 00:56:11 UTC) #5
pfeldman
https://codereview.chromium.org/2217783002/diff/80001/third_party/WebKit/Source/devtools/front_end/ui/View.js File third_party/WebKit/Source/devtools/front_end/ui/View.js (right): https://codereview.chromium.org/2217783002/diff/80001/third_party/WebKit/Source/devtools/front_end/ui/View.js#newcode346 third_party/WebKit/Source/devtools/front_end/ui/View.js:346: createTabbedLocation: function(revealCallback, location, restoreSelection) On 2016/08/06 00:56:11, dgozman wrote: ...
4 years, 4 months ago (2016-08-06 01:12:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2217783002/100001
4 years, 4 months ago (2016-08-06 01:19:24 UTC) #9
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 4 months ago (2016-08-06 03:34:26 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-06 03:36:44 UTC) #12
Message was sent while issue was closed. 
Patchset 6 (id:??) landed as
https://crrev.com/c58d14b485ad001da13adaced10dcdfeb6983c7a
Cr-Commit-Position: refs/heads/master@{#410260}

Powered by Google App Engine
This is Rietveld 408576698