third_party/WebKit/Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js - Issue 2217783002: DevTools: use view locations in the elements and sources sidebars.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js

Issue 2217783002: DevTools: use view locations in the elements and sources sidebars. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: for landing Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/components/BreakpointsSidebarPaneBase.js ('k') | third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js

diff --git a/third_party/WebKit/Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js b/third_party/WebKit/Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js

index 7f7b6ccc1f6afe13c5344f6ba9844150966d6b98..51424e17178a30c108603e213ebf8cd8f335fd65 100644

--- a/third_party/WebKit/Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js

+++ b/third_party/WebKit/Source/devtools/front_end/components/DOMBreakpointsSidebarPane.js

@@ -326,7 +326,7 @@ WebInspector.DOMBreakpointsSidebarPane.prototype = {

var element = this._breakpointElements[breakpointId];

if (!element)

return;

- this.revealWidget();

+ this.revealView();

element.classList.add("breakpoint-hit");

this._highlightedElement = element;

@@ -419,13 +419,13 @@ WebInspector.DOMBreakpointsSidebarPane.prototype = {

/**

* @constructor

- * @extends {WebInspector.View}

+ * @extends {WebInspector.SimpleView}

* @param {!WebInspector.DOMBreakpointsSidebarPane} pane

* @param {!WebInspector.Panel} panel

WebInspector.DOMBreakpointsSidebarPane.Proxy = function(pane, panel)

{

- WebInspector.View.call(this, WebInspector.UIString("DOM Breakpoints"));

+ WebInspector.SimpleView.call(this, WebInspector.UIString("DOM Breakpoints"));

this.registerRequiredCSS("components/breakpointsList.css");

this._wrappedPane = pane;

@@ -435,7 +435,7 @@ WebInspector.DOMBreakpointsSidebarPane.Proxy = function(pane, panel)

WebInspector.DOMBreakpointsSidebarPane.Proxy.prototype = {

wasShown: function()

{

- WebInspector.View.prototype.wasShown.call(this);

+ WebInspector.SimpleView.prototype.wasShown.call(this);

this._reattachBody();

@@ -445,7 +445,7 @@ WebInspector.DOMBreakpointsSidebarPane.Proxy.prototype = {

this._wrappedPane.show(this.element);

- __proto__: WebInspector.View.prototype

+ __proto__: WebInspector.SimpleView.prototype

}

/**