third_party/WebKit/Source/devtools/front_end/audits/AuditsPanel.js - Issue 2217783002: DevTools: use view locations in the elements and sources sidebars.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/audits/AuditsPanel.js

Issue 2217783002: DevTools: use view locations in the elements and sources sidebars. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: for landing Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/audits/AuditResultView.js ('k') | third_party/WebKit/Source/devtools/front_end/components/BreakpointsSidebarPaneBase.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/audits/AuditsPanel.js

diff --git a/third_party/WebKit/Source/devtools/front_end/audits/AuditsPanel.js b/third_party/WebKit/Source/devtools/front_end/audits/AuditsPanel.js

index a51f8ee85d5b7a0709cbbdaf125f06892f85da71..dbacdd497036813de0ad3e5c14ab6edee3528749 100644

--- a/third_party/WebKit/Source/devtools/front_end/audits/AuditsPanel.js

+++ b/third_party/WebKit/Source/devtools/front_end/audits/AuditsPanel.js

@@ -129,14 +129,14 @@ WebInspector.AuditsPanel.prototype = {

showResults: function(categoryResults)

{

- if (!categoryResults._resultView) {

+ if (!categoryResults._resultLocation) {

categoryResults.sort((a, b) => (a.title || "").localeCompare(b.title || ""));

- var resultView = new WebInspector.View.ExpandableStackContainer();

+ var resultView = WebInspector.viewManager.createStackLocation();

for (var i = 0; i < categoryResults.length; ++i)

- resultView.appendView(new WebInspector.AuditCategoryResultPane(categoryResults[i]), true);

- categoryResults._resultView = resultView;

+ resultView.showView(new WebInspector.AuditCategoryResultPane(categoryResults[i]));

+ categoryResults._resultLocation = resultView;

}

- this.visibleView = categoryResults._resultView;

+ this.visibleView = categoryResults._resultLocation.widget();

showLauncherView: function()