third_party/WebKit/Source/devtools/front_end/ui/InspectorView.js - Issue 2217783002: DevTools: use view locations in the elements and sources sidebars.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/ui/InspectorView.js

Issue 2217783002: DevTools: use view locations in the elements and sources sidebars. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: for landing Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/sources/module.json ('k') | third_party/WebKit/Source/devtools/front_end/ui/TabbedPane.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/ui/InspectorView.js

diff --git a/third_party/WebKit/Source/devtools/front_end/ui/InspectorView.js b/third_party/WebKit/Source/devtools/front_end/ui/InspectorView.js

index 87f968c4adf612d20acd4442239ed99b2cab6d9b..571f8f0030ac2154d786953bdc9356c15d42edc4 100644

--- a/third_party/WebKit/Source/devtools/front_end/ui/InspectorView.js

+++ b/third_party/WebKit/Source/devtools/front_end/ui/InspectorView.js

@@ -47,7 +47,8 @@ WebInspector.InspectorView = function()

this._drawerSplitWidget.show(this.element);

// Create drawer tabbed pane.

- this._drawerTabbedLocation = WebInspector.viewManager.createTabbedLocation("drawer-view", true, true);

+ this._drawerTabbedLocation = WebInspector.viewManager.createTabbedLocation(this.showDrawer.bind(this), "drawer-view", true);

+ this._drawerTabbedLocation.enableMoreTabsButton();

this._drawerTabbedPane = this._drawerTabbedLocation.tabbedPane();

this._drawerTabbedPane.setMinimumSize(0, 27);

var drawerToolbar = new WebInspector.Toolbar("drawer-close-toolbar");

@@ -123,9 +124,8 @@ WebInspector.InspectorView.prototype = {

* @param {string} locationName

* @return {?WebInspector.ViewLocation}

- revealLocation: function(locationName)

+ resolveLocation: function(locationName)

{

- this.showDrawer();

return this._drawerTabbedLocation;