third_party/WebKit/LayoutTests/http/tests/inspector/elements/event-listeners-framework-with-service-worker.html - Issue 2217783002: DevTools: use view locations in the elements and sources sidebars.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/inspector/elements/event-listeners-framework-with-service-worker.html

Issue 2217783002: DevTools: use view locations in the elements and sources sidebars. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: for landing Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/inspector/elements-test.js ('k') | third_party/WebKit/LayoutTests/http/tests/inspector/elements/event-listeners-framework-with-service-worker-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/inspector/elements/event-listeners-framework-with-service-worker.html

diff --git a/third_party/WebKit/LayoutTests/http/tests/inspector/elements/event-listeners-framework-with-service-worker.html b/third_party/WebKit/LayoutTests/http/tests/inspector/elements/event-listeners-framework-with-service-worker.html

index c2863505906369f5cc4a1cc09d6938ea3a72479a..dfd8bf9ce7b81ce9ad109aa6b45ceb4fef3f51ff 100644

--- a/third_party/WebKit/LayoutTests/http/tests/inspector/elements/event-listeners-framework-with-service-worker.html

+++ b/third_party/WebKit/LayoutTests/http/tests/inspector/elements/event-listeners-framework-with-service-worker.html

@@ -22,12 +22,6 @@ function test()

return InspectorTest.isDedicatedWorker(target);

}

- function forceUpdate()

- {

- objectEventListenersPane.revealWidget();

- objectEventListenersPane.update();

- }

function step1(target)

{

InspectorTest.waitForExecutionContextInTarget(target, step2);

@@ -39,7 +33,10 @@ function test()

InspectorTest.selectThread(executionContext.target());

InspectorTest.addResult("Context is dedicated worker: " + isDedicatedWorker());

InspectorTest.addResult("Dumping listeners");

- InspectorTest.expandAndDumpEventListeners(objectEventListenersPane._eventListenersView, forceUpdate, step3);

+ objectEventListenersPane.revealView().then(() => {

+ objectEventListenersPane.update();

+ InspectorTest.expandAndDumpEventListeners(objectEventListenersPane._eventListenersView, step3);

+ });

}

function step3()

@@ -48,7 +45,7 @@ function test()

InspectorTest.selectThread(WebInspector.targetManager.mainTarget());

InspectorTest.addResult("Context is dedicated worker: " + isDedicatedWorker());

InspectorTest.addResult("Dumping listeners");

- InspectorTest.expandAndDumpEventListeners(objectEventListenersPane._eventListenersView, forceUpdate, step4);

+ InspectorTest.expandAndDumpEventListeners(objectEventListenersPane._eventListenersView, step4);

}

function step4()