Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 2215613002: MD History: Improve dom-if usage in history-item (Closed)

Created:
4 years, 4 months ago by tsergeant
Modified:
4 years, 4 months ago
Reviewers:
calamity
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, dbeam+watch-history_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@history_improve_collapse_button
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD History: Improve dom-if usage in history-item This adds a dom-if to the bookmark star, which is rarely shown and takes time to stamp. Also removes a dom-if from a very light div which did not need the conditional stamping. In artificial tests, this saves about 10% of the time to stamp a list of history-items. This should correspond to a small, 1-2% improvement on the main history page. BUG=629710 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/534998a0abe5f0a40cb87ead60162090101ce43f Cr-Commit-Position: refs/heads/master@{#410313}

Patch Set 1 #

Patch Set 2 : Fix tests #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -27 lines) Patch
M chrome/browser/resources/md_history/grouped_list.html View 1 chunk +0 lines, -1 line 2 comments Download
M chrome/browser/resources/md_history/history_item.html View 1 3 chunks +14 lines, -13 lines 0 comments Download
M chrome/browser/resources/md_history/history_item.js View 1 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/resources/md_history/history_list.html View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/data/webui/md_history/history_item_test.js View 1 1 chunk +4 lines, -8 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 23 (17 generated)
tsergeant
4 years, 4 months ago (2016-08-08 04:19:29 UTC) #10
calamity
lgtm https://codereview.chromium.org/2215613002/diff/40001/chrome/browser/resources/md_history/grouped_list.html File chrome/browser/resources/md_history/grouped_list.html (left): https://codereview.chromium.org/2215613002/diff/40001/chrome/browser/resources/md_history/grouped_list.html#oldcode1 chrome/browser/resources/md_history/grouped_list.html:1: <link rel="import" href="chrome://resources/html/polymer.html"> CL comment: s/artifial/artificial/
4 years, 4 months ago (2016-08-08 06:34:05 UTC) #15
tsergeant
https://codereview.chromium.org/2215613002/diff/40001/chrome/browser/resources/md_history/grouped_list.html File chrome/browser/resources/md_history/grouped_list.html (left): https://codereview.chromium.org/2215613002/diff/40001/chrome/browser/resources/md_history/grouped_list.html#oldcode1 chrome/browser/resources/md_history/grouped_list.html:1: <link rel="import" href="chrome://resources/html/polymer.html"> On 2016/08/08 06:34:05, calamity wrote: > ...
4 years, 4 months ago (2016-08-08 07:36:44 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2215613002/40001
4 years, 4 months ago (2016-08-08 07:37:02 UTC) #19
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 4 months ago (2016-08-08 07:40:29 UTC) #21
commit-bot: I haz the power
4 years, 4 months ago (2016-08-08 07:42:12 UTC) #23
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/534998a0abe5f0a40cb87ead60162090101ce43f
Cr-Commit-Position: refs/heads/master@{#410313}

Powered by Google App Engine
This is Rietveld 408576698