Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Side by Side Diff: chrome/browser/resources/md_history/history_item.html

Issue 2215613002: MD History: Improve dom-if usage in history-item (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@history_improve_collapse_button
Patch Set: Fix tests Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 <link rel="import" href="chrome://resources/cr_elements/icons.html"> 1 <link rel="import" href="chrome://resources/cr_elements/icons.html">
2 <link rel="import" href="chrome://resources/html/polymer.html"> 2 <link rel="import" href="chrome://resources/html/polymer.html">
3 <link rel="import" href="chrome://resources/polymer/v1_0/iron-flex-layout/iron-f lex-layout.html"> 3 <link rel="import" href="chrome://resources/polymer/v1_0/iron-flex-layout/iron-f lex-layout.html">
4 <link rel="import" href="chrome://resources/polymer/v1_0/iron-icon/iron-icon.htm l"> 4 <link rel="import" href="chrome://resources/polymer/v1_0/iron-icon/iron-icon.htm l">
5 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-butt on.html"> 5 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-butt on.html">
6 <link rel="import" href="chrome://resources/polymer/v1_0/paper-checkbox/paper-ch eckbox.html"> 6 <link rel="import" href="chrome://resources/polymer/v1_0/paper-checkbox/paper-ch eckbox.html">
7 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button-light.html"> 7 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button-light.html">
8 <link rel="import" href="chrome://resources/html/icon.html"> 8 <link rel="import" href="chrome://resources/html/icon.html">
9 <link rel="import" href="chrome://resources/html/util.html"> 9 <link rel="import" href="chrome://resources/html/util.html">
10 <link rel="import" href="chrome://history/browser_service.html"> 10 <link rel="import" href="chrome://history/browser_service.html">
(...skipping 86 matching lines...) Expand 10 before | Expand all | Expand 10 after
97 #domain { 97 #domain {
98 -webkit-margin-start: 16px; 98 -webkit-margin-start: 16px;
99 color: var(--secondary-text-color); 99 color: var(--secondary-text-color);
100 flex-shrink: 0; 100 flex-shrink: 0;
101 } 101 }
102 102
103 #menu-button { 103 #menu-button {
104 -webkit-margin-end: 12px; 104 -webkit-margin-end: 12px;
105 } 105 }
106 106
107 #bookmark-star { 107 #star-container {
108 -webkit-margin-end: 4px; 108 -webkit-margin-end: 4px;
109 -webkit-margin-start: 12px; 109 -webkit-margin-start: 12px;
110 color: rgb(68, 136, 255);
111 height: 32px;
112 visibility: hidden;
113 width: 32px; 110 width: 32px;
114 } 111 }
115 112
113 #bookmark-star {
114 color: rgb(68, 136, 255);
115 height: 32px;
116 width: 32px;
117 }
118
116 #bookmark-star iron-icon { 119 #bookmark-star iron-icon {
117 height: 16px; 120 height: 16px;
118 width: 16px; 121 width: 16px;
119 } 122 }
120 123
121 :host([starred]) #bookmark-star {
122 visibility: visible;
123 }
124
125 #time-gap-separator { 124 #time-gap-separator {
126 -webkit-border-start: 1px solid #888; 125 -webkit-border-start: 1px solid #888;
127 -webkit-margin-start: 77px; 126 -webkit-margin-start: 77px;
128 height: 15px; 127 height: 15px;
129 } 128 }
130 </style> 129 </style>
131 130
132 <div id="sizing-container"> 131 <div id="sizing-container">
133 <div id="main-container"> 132 <div id="main-container">
134 <div id="date-accessed" class="card-title"> 133 <div id="date-accessed" class="card-title">
135 [[cardTitle_(numberOfItems, item.dateRelativeDay, searchTerm)]] 134 [[cardTitle_(numberOfItems, item.dateRelativeDay, searchTerm)]]
136 </div> 135 </div>
137 <div id="item-container"> 136 <div id="item-container">
138 <paper-checkbox id="checkbox" on-tap="onCheckboxSelected_" 137 <paper-checkbox id="checkbox" on-tap="onCheckboxSelected_"
139 checked="{{selected}}" disabled="[[selectionNotAllowed_()]]"> 138 checked="{{selected}}" disabled="[[selectionNotAllowed_()]]">
140 </paper-checkbox> 139 </paper-checkbox>
141 <span id="time-accessed">[[item.readableTimestamp]]</span> 140 <span id="time-accessed">[[item.readableTimestamp]]</span>
142 <div class="website-icon" id="icon"></div> 141 <div class="website-icon" id="icon"></div>
143 <div id="title-and-domain"> 142 <div id="title-and-domain">
144 <a href="[[item.url]]" id="title" class="website-title"> 143 <a href="[[item.url]]" id="title" class="website-title">
145 <history-searched-label title="[[cropItemTitle_(item.title)]]" 144 <history-searched-label title="[[cropItemTitle_(item.title)]]"
146 search-term="[[searchTerm]]"></history-searched-label> 145 search-term="[[searchTerm]]"></history-searched-label>
147 </a> 146 </a>
148 <span id="domain">[[item.domain]]</span> 147 <span id="domain">[[item.domain]]</span>
149 </div> 148 </div>
150 <button is="paper-icon-button-light" id="bookmark-star" 149 <div id="star-container">
151 title="$i18n{removeBookmark}" on-tap="onRemoveBookmarkTap_"> 150 <template is="dom-if" if="[[item.starred]]">
152 <iron-icon icon="cr:star"></iron-icon> 151 <button is="paper-icon-button-light" id="bookmark-star"
153 </button> 152 title="$i18n{removeBookmark}" on-tap="onRemoveBookmarkTap_">
153 <iron-icon icon="cr:star"></iron-icon>
154 </button>
155 </template>
156 </div>
154 <button is="paper-icon-button-light" id="menu-button" 157 <button is="paper-icon-button-light" id="menu-button"
155 class="icon-button" title="$i18n{moreActionsButton}" 158 class="icon-button" title="$i18n{moreActionsButton}"
156 on-tap="onMenuButtonTap_"> 159 on-tap="onMenuButtonTap_">
157 <iron-icon icon="cr:more-vert"></iron-icon> 160 <iron-icon icon="cr:more-vert"></iron-icon>
158 </button> 161 </button>
159 </div> 162 </div>
160 <template is="dom-if" if="[[hasTimeGap]]"> 163 <div id="time-gap-separator" hidden="[[!hasTimeGap]]"></div>
161 <div id="time-gap-separator"></div>
162 </template>
163 </div> 164 </div>
164 </div> 165 </div>
165 </template> 166 </template>
166 <script src="chrome://history/history_item.js"></script> 167 <script src="chrome://history/history_item.js"></script>
167 </dom-module> 168 </dom-module>
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698