Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5133)

Unified Diff: chrome/browser/resources/md_history/history_item.html

Issue 2215613002: MD History: Improve dom-if usage in history-item (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@history_improve_collapse_button
Patch Set: Fix tests Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/md_history/history_item.html
diff --git a/chrome/browser/resources/md_history/history_item.html b/chrome/browser/resources/md_history/history_item.html
index 44bb6c66a13ba7d97c0b52e98c0e16c175f31d22..28de1418a0c268dd942967fe6bc2ccb1a3af4a9e 100644
--- a/chrome/browser/resources/md_history/history_item.html
+++ b/chrome/browser/resources/md_history/history_item.html
@@ -104,12 +104,15 @@
-webkit-margin-end: 12px;
}
- #bookmark-star {
+ #star-container {
-webkit-margin-end: 4px;
-webkit-margin-start: 12px;
+ width: 32px;
+ }
+
+ #bookmark-star {
color: rgb(68, 136, 255);
height: 32px;
- visibility: hidden;
width: 32px;
}
@@ -118,10 +121,6 @@
width: 16px;
}
- :host([starred]) #bookmark-star {
- visibility: visible;
- }
-
#time-gap-separator {
-webkit-border-start: 1px solid #888;
-webkit-margin-start: 77px;
@@ -147,19 +146,21 @@
</a>
<span id="domain">[[item.domain]]</span>
</div>
- <button is="paper-icon-button-light" id="bookmark-star"
- title="$i18n{removeBookmark}" on-tap="onRemoveBookmarkTap_">
- <iron-icon icon="cr:star"></iron-icon>
- </button>
+ <div id="star-container">
+ <template is="dom-if" if="[[item.starred]]">
+ <button is="paper-icon-button-light" id="bookmark-star"
+ title="$i18n{removeBookmark}" on-tap="onRemoveBookmarkTap_">
+ <iron-icon icon="cr:star"></iron-icon>
+ </button>
+ </template>
+ </div>
<button is="paper-icon-button-light" id="menu-button"
class="icon-button" title="$i18n{moreActionsButton}"
on-tap="onMenuButtonTap_">
<iron-icon icon="cr:more-vert"></iron-icon>
</button>
</div>
- <template is="dom-if" if="[[hasTimeGap]]">
- <div id="time-gap-separator"></div>
- </template>
+ <div id="time-gap-separator" hidden="[[!hasTimeGap]]"></div>
</div>
</div>
</template>

Powered by Google App Engine
This is Rietveld 408576698