chrome/browser/resources/md_history/history_item.js - Issue 2215613002: MD History: Improve dom-if usage in history-item

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/md_history/history_item.js

Issue 2215613002: MD History: Improve dom-if usage in history-item (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@history_improve_collapse_button

Patch Set: Fix tests Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/md_history/grouped_list.html ('K') | « chrome/browser/resources/md_history/history_item.html ('k') | chrome/browser/resources/md_history/history_list.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/md_history/history_item.js

diff --git a/chrome/browser/resources/md_history/history_item.js b/chrome/browser/resources/md_history/history_item.js

index 5a3fa265364c27cd8df7618ddb807c0c770451e1..314635932f81e43526256676edc04a0a2ce310ef 100644

--- a/chrome/browser/resources/md_history/history_item.js

+++ b/chrome/browser/resources/md_history/history_item.js

@@ -11,9 +11,6 @@ cr.define('md_history', function() {

// from the history backend, as well as fields computed by history-list.

item: {type: Object, observer: 'showIcon_'},

- // True if the website is a bookmarked page.

- starred: {type: Boolean, reflectToAttribute: true},

// Search term used to obtain this history-item.

searchTerm: {type: String},

@@ -50,7 +47,10 @@ cr.define('md_history', function() {

* @private

onRemoveBookmarkTap_: function() {

- if (this.$['bookmark-star'] == this.root.activeElement)

+ if (!this.item.starred)

+ return;

+ if (this.$$('#bookmark-star') == this.root.activeElement)

this.$['menu-button'].focus();

md_history.BrowserService.getInstance()