Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Side by Side Diff: chrome/browser/resources/md_history/grouped_list.html

Issue 2215613002: MD History: Improve dom-if usage in history-item (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@history_improve_collapse_button
Patch Set: Fix tests Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/md_history/history_item.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <link rel="import" href="chrome://resources/html/polymer.html"> 1 <link rel="import" href="chrome://resources/html/polymer.html">
calamity 2016/08/08 06:34:05 CL comment: s/artifial/artificial/
tsergeant 2016/08/08 07:36:44 Done.
2 <link rel="import" href="chrome://resources/polymer/v1_0/iron-collapse/iron-coll apse.html"> 2 <link rel="import" href="chrome://resources/polymer/v1_0/iron-collapse/iron-coll apse.html">
3 <link rel="import" href="chrome://resources/polymer/v1_0/iron-icon/iron-icon.htm l"> 3 <link rel="import" href="chrome://resources/polymer/v1_0/iron-icon/iron-icon.htm l">
4 <link rel="import" href="chrome://history/constants.html"> 4 <link rel="import" href="chrome://history/constants.html">
5 <link rel="import" href="chrome://history/history_item.html"> 5 <link rel="import" href="chrome://history/history_item.html">
6 <link rel="import" href="chrome://history/shared_style.html"> 6 <link rel="import" href="chrome://history/shared_style.html">
7 7
8 <dom-module id="history-grouped-list"> 8 <dom-module id="history-grouped-list">
9 <template> 9 <template>
10 <style include="shared-style"> 10 <style include="shared-style">
11 :host { 11 :host {
(...skipping 77 matching lines...) Expand 10 before | Expand all | Expand 10 after
89 <span class="domain-count">[[domain.visits.length]]</span> 89 <span class="domain-count">[[domain.visits.length]]</span>
90 </div> 90 </div>
91 <iron-icon icon="[[getDropdownIcon_(domain.expanded)]]" 91 <iron-icon icon="[[getDropdownIcon_(domain.expanded)]]"
92 class="dropdown-indicator"></iron-icon> 92 class="dropdown-indicator"></iron-icon>
93 </div> 93 </div>
94 <iron-collapse opened="{{domain.expanded}}" id="collapse"> 94 <iron-collapse opened="{{domain.expanded}}" id="collapse">
95 <template is="dom-if" if="[[domain.rendered]]"> 95 <template is="dom-if" if="[[domain.rendered]]">
96 <template is="dom-repeat" items="[[domain.visits]]" 96 <template is="dom-repeat" items="[[domain.visits]]"
97 as="item" initial-count="5" index-as="itemIndex"> 97 as="item" initial-count="5" index-as="itemIndex">
98 <history-item item="[[item]]" 98 <history-item item="[[item]]"
99 starred="[[item.starred]]"
100 selected="{{item.selected}}" 99 selected="{{item.selected}}"
101 has-time-gap="[[needsTimeGap_( 100 has-time-gap="[[needsTimeGap_(
102 groupIndex, domainIndex, itemIndex)]]" 101 groupIndex, domainIndex, itemIndex)]]"
103 search-term="[[searchedTerm]]" 102 search-term="[[searchedTerm]]"
104 number-of-items="[[historyData.length]]" 103 number-of-items="[[historyData.length]]"
105 embedded> 104 embedded>
106 </history-item> 105 </history-item>
107 </template> 106 </template>
108 </template> 107 </template>
109 </iron-collapse> 108 </iron-collapse>
110 </div> 109 </div>
111 </template> 110 </template>
112 </div> 111 </div>
113 </template> 112 </template>
114 </div> 113 </div>
115 </template> 114 </template>
116 <script src="chrome://history/grouped_list.js"></script> 115 <script src="chrome://history/grouped_list.js"></script>
117 </dom-module> 116 </dom-module>
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/resources/md_history/history_item.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698