Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 2215433003: Revert of SkRTConf: reduce functionality to what we use, increase simplicity (Closed)

Created:
4 years, 4 months ago by mtklein
Modified:
4 years, 4 months ago
Reviewers:
hal.canary
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of SkRTConf: reduce functionality to what we use, increase simplicity (patchset #8 id:150001 of https://codereview.chromium.org/2212473002/ ) Reason for revert: missed GrVkPipelineStateCache Original issue's description: > SkRTConf: reduce functionality to what we use, increase simplicity > > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2212473002 > DOCS_PREVIEW= https://skia.org/?cl=2212473002 > CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot > > [mtklein] > TBR=reed@google.com > Only removing unused public API. > > Committed: https://skia.googlesource.com/skia/+/ef59974708dade6fa72fb0218d4f8a9590175c47 TBR=halcanary@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/b97963401220da82455e0dfe1f7206e7e8b249e1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+894 lines, -13 lines) Patch
M BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M gyp/utils.gypi View 2 chunks +2 lines, -0 lines 0 comments Download
A include/utils/SkRTConf.h View 1 chunk +193 lines, -0 lines 0 comments Download
A site/dev/runtime/config.md View 1 chunk +89 lines, -0 lines 0 comments Download
A site/dev/runtime/index.md View 1 chunk +181 lines, -0 lines 0 comments Download
M src/core/SkGraphics.cpp View 2 chunks +10 lines, -0 lines 0 comments Download
M src/effects/SkBlurMaskFilter.cpp View 3 chunks +4 lines, -5 lines 0 comments Download
M src/gpu/batches/GrAADistanceFieldPathRenderer.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/gl/GrGLGpuProgramCache.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/gl/builders/GrGLShaderStringBuilder.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M src/gpu/vk/GrVkPipelineStateCache.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/images/SkJPEGImageEncoder.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/images/SkPNGImageEncoder.cpp View 2 chunks +6 lines, -3 lines 0 comments Download
M src/opts/opts_check_x86.cpp View 1 chunk +1 line, -0 lines 0 comments Download
A src/utils/SkRTConf.cpp View 1 chunk +325 lines, -0 lines 0 comments Download
M tests/PathOpsExtendedTest.cpp View 2 chunks +5 lines, -0 lines 0 comments Download
M tests/PathOpsSkpClipTest.cpp View 8 chunks +13 lines, -1 line 0 comments Download
A tests/RTConfRegistryTest.cpp View 1 chunk +25 lines, -0 lines 0 comments Download
A tests/RuntimeConfigTest.cpp View 1 chunk +28 lines, -0 lines 0 comments Download
M tests/SkpSkGrTest.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
mtklein
Created Revert of SkRTConf: reduce functionality to what we use, increase simplicity
4 years, 4 months ago (2016-08-04 02:19:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2215433003/1
4 years, 4 months ago (2016-08-04 02:19:40 UTC) #3
commit-bot: I haz the power
4 years, 4 months ago (2016-08-04 02:19:52 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/b97963401220da82455e0dfe1f7206e7e8b249e1

Powered by Google App Engine
This is Rietveld 408576698