src/images/SkPNGImageEncoder.cpp - Issue 2215433003: Revert of SkRTConf: reduce functionality to what we use, increase simplicity

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/images/SkPNGImageEncoder.cpp

Issue 2215433003: Revert of SkRTConf: reduce functionality to what we use, increase simplicity (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/images/SkPNGImageEncoder.cpp

diff --git a/src/images/SkPNGImageEncoder.cpp b/src/images/SkPNGImageEncoder.cpp

index 1932e66dc6ae33ae968e958647ac037371eb890f..c3df5d10a874e5243b94d84c16b2e6f375aeb910 100644

--- a/src/images/SkPNGImageEncoder.cpp

+++ b/src/images/SkPNGImageEncoder.cpp

@@ -10,6 +10,7 @@

#include "SkColorPriv.h"

#include "SkDither.h"

#include "SkMath.h"

+#include "SkRTConf.h"

#include "SkStream.h"

#include "SkTemplates.h"

#include "SkUtils.h"

@@ -35,9 +36,11 @@

#endif

#define DEFAULT_FOR_SUPPRESS_PNG_IMAGE_DECODER_WARNINGS true

-// Suppress most PNG warnings when calling image decode functions.

-static const bool c_suppressPNGImageDecoderWarnings{

- DEFAULT_FOR_SUPPRESS_PNG_IMAGE_DECODER_WARNINGS};

+SK_CONF_DECLARE(bool, c_suppressPNGImageDecoderWarnings,

+ "images.png.suppressDecoderWarnings",

+ DEFAULT_FOR_SUPPRESS_PNG_IMAGE_DECODER_WARNINGS,

+ "Suppress most PNG warnings when calling image decode "

+ "functions.");

///////////////////////////////////////////////////////////////////////////////

« no previous file with comments | « src/images/SkJPEGImageEncoder.cpp ('k') | src/opts/opts_check_x86.cpp » ('j') | no next file with comments »