SkRTConf: eliminate

SkRTConf: eliminate

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2212473002
DOCS_PREVIEW= https://skia.org/?cl=2212473002
CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot

[mtklein]
TBR=reed@google.com
Only removing unused public API.

Committed: https://skia.googlesource.com/skia/+/4e44efe50474d4eebcb30b762e784b3ef2126750

[hal.canary, 2016-08-03 17:00:29]

Description was changed from

==========
SkRTConf: reduce functionality to what we use, increase simplicity
==========

to

==========
SkRTConf: reduce functionality to what we use, increase simplicity
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2212473002
DOCS_PREVIEW= https://skia.org/?cl=2212473002
==========

[hal.canary, 2016-08-03 17:01:15]

Patchset #1 (id:1) has been deleted

[hal.canary, 2016-08-03 17:01:19]

The CQ bit was checked by halcanary@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-03 17:01:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hal.canary, 2016-08-03 17:01:27]

Description was changed from

==========
SkRTConf: reduce functionality to what we use, increase simplicity
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2212473002
DOCS_PREVIEW= https://skia.org/?cl=2212473002
==========

to

==========
SkRTConf: reduce functionality to what we use, increase simplicity

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2212473002
DOCS_PREVIEW= https://skia.org/?cl=2212473002
==========

[hal.canary, 2016-08-03 17:04:31]

halcanary@google.com changed reviewers:
+ mtklein@google.com

[hal.canary, 2016-08-03 17:04:31]

here's a first pass at simplification

ptal

[commit-bot: I haz the power, 2016-08-03 17:04:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-03 17:04:55]

Dry run: Try jobs failed on following builders:
  Build-Mac-Clang-x86_64-Release-Trybot on master.client.skia.compile
(JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Mac-Clang-x86_...)
  Build-Ubuntu-Clang-x86_64-Debug-Trybot on master.client.skia.compile
(JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x...)

[hal.canary, 2016-08-03 17:25:57]

The CQ bit was checked by halcanary@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-03 17:26:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-03 17:33:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-03 17:34:00]

Dry run: Try jobs failed on following builders:
  Build-Win-MSVC-x86-Debug-Trybot on master.client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-D...)

[hal.canary, 2016-08-03 17:34:05]

Description was changed from

==========
SkRTConf: reduce functionality to what we use, increase simplicity

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2212473002
DOCS_PREVIEW= https://skia.org/?cl=2212473002
==========

to

==========
SkRTConf: reduce functionality to what we use, increase simplicity

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2212473002
DOCS_PREVIEW= https://skia.org/?cl=2212473002
CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
==========

[hal.canary, 2016-08-03 17:34:12]

The CQ bit was checked by halcanary@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-03 17:34:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-03 17:37:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-03 17:37:51]

Dry run: Try jobs failed on following builders:
  Build-Ubuntu-GCC-Mips-Debug-Android-Trybot on master.client.skia.compile
(JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Mip...)

[mtklein, 2016-08-03 17:43:21]

make sure we get tests/SkpSkGrTest.cpp and tools/whitelist_typefaces.cpp too?

https://codereview.chromium.org/2212473002/diff/60001/tests/PathOpsExtendedTe...
File tests/PathOpsExtendedTest.cpp (right):

https://codereview.chromium.org/2212473002/diff/60001/tests/PathOpsExtendedTe...
tests/PathOpsExtendedTest.cpp:633:
SK_CONF_SET("images.jpeg.suppressDecoderWarnings", true);
Kill?

https://codereview.chromium.org/2212473002/diff/60001/tests/PathOpsSkpClipTes...
File tests/PathOpsSkpClipTest.cpp (right):

https://codereview.chromium.org/2212473002/diff/60001/tests/PathOpsSkpClipTes...
tests/PathOpsSkpClipTest.cpp:745: c_suppressPNGImageDecoderWarnings = true;
let's delete this for real

[hal.canary, 2016-08-03 18:27:06]

The CQ bit was checked by halcanary@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-03 18:27:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-03 18:58:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-03 18:58:56]

Dry run: This issue passed the CQ dry run.

[mtklein, 2016-08-03 21:01:14]

lgtm

https://codereview.chromium.org/2212473002/diff/110001/src/effects/SkBlurMask...
File src/effects/SkBlurMaskFilter.cpp (right):

https://codereview.chromium.org/2212473002/diff/110001/src/effects/SkBlurMask...
src/effects/SkBlurMaskFilter.cpp:306: // Use the faster analytic blur approach
for ninepatch rects
ninepatch round rects...

[hal.canary, 2016-08-03 21:23:44]

https://codereview.chromium.org/2212473002/diff/60001/tests/PathOpsExtendedTe...
File tests/PathOpsExtendedTest.cpp (right):

https://codereview.chromium.org/2212473002/diff/60001/tests/PathOpsExtendedTe...
tests/PathOpsExtendedTest.cpp:633:
SK_CONF_SET("images.jpeg.suppressDecoderWarnings", true);
On 2016/08/03 17:43:20, mtklein wrote:
> Kill?

Done.

https://codereview.chromium.org/2212473002/diff/60001/tests/PathOpsSkpClipTes...
File tests/PathOpsSkpClipTest.cpp (right):

https://codereview.chromium.org/2212473002/diff/60001/tests/PathOpsSkpClipTes...
tests/PathOpsSkpClipTest.cpp:745: c_suppressPNGImageDecoderWarnings = true;
On 2016/08/03 17:43:21, mtklein wrote:
> let's delete this for real

Done.

https://codereview.chromium.org/2212473002/diff/110001/src/effects/SkBlurMask...
File src/effects/SkBlurMaskFilter.cpp (right):

https://codereview.chromium.org/2212473002/diff/110001/src/effects/SkBlurMask...
src/effects/SkBlurMaskFilter.cpp:306: // Use the faster analytic blur approach
for ninepatch rects
On 2016/08/03 21:01:14, mtklein wrote:
> ninepatch round rects...

Done.

[hal.canary, 2016-08-03 21:23:48]

The CQ bit was checked by halcanary@google.com

[hal.canary, 2016-08-03 21:23:49]

The patchset sent to the CQ was uploaded after l-g-t-m from mtklein@google.com
Link to the patchset: https://codereview.chromium.org/2212473002/#ps130001
(title: "2016-08-03 (Wednesday) 17:19:04 EDT")

[commit-bot: I haz the power, 2016-08-03 21:24:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-03 21:25:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-03 21:25:49]

Try jobs failed on following builders:
  Build-Ubuntu-Clang-x86_64-Debug-GN-Trybot on master.client.skia.compile
(JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x...)
  Build-Ubuntu-GCC-x86_64-Release-GN-Trybot on master.client.skia.compile
(JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86...)
  skia_presubmit-Trybot on master.client.skia.fyi (JOB_FAILED,
http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/bu...)

[mtklein, 2016-08-03 21:57:02]

The CQ bit was checked by mtklein@google.com

[mtklein, 2016-08-03 21:57:02]

The patchset sent to the CQ was uploaded after l-g-t-m from mtklein@google.com
Link to the patchset: https://codereview.chromium.org/2212473002/#ps150001
(title: "2016-08-03 (Wednesday) 17:31:49 EDT")

[commit-bot: I haz the power, 2016-08-03 21:57:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-03 21:58:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-03 21:58:35]

Try jobs failed on following builders:
  skia_presubmit-Trybot on master.client.skia.fyi (JOB_FAILED,
http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/bu...)

[mtklein, 2016-08-03 22:04:19]

Description was changed from

==========
SkRTConf: reduce functionality to what we use, increase simplicity

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2212473002
DOCS_PREVIEW= https://skia.org/?cl=2212473002
CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
==========

to

==========
SkRTConf: reduce functionality to what we use, increase simplicity

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2212473002
DOCS_PREVIEW= https://skia.org/?cl=2212473002
CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot

[mtklein]
TBR=reed@google.com
Only removing unused public API.
==========

[mtklein, 2016-08-03 22:04:26]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2016-08-03 22:04:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-03 22:30:41]

Description was changed from

==========
SkRTConf: reduce functionality to what we use, increase simplicity

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2212473002
DOCS_PREVIEW= https://skia.org/?cl=2212473002
CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot

[mtklein]
TBR=reed@google.com
Only removing unused public API.
==========

to

==========
SkRTConf: reduce functionality to what we use, increase simplicity

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2212473002
DOCS_PREVIEW= https://skia.org/?cl=2212473002
CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot

[mtklein]
TBR=reed@google.com
Only removing unused public API.

Committed:
https://skia.googlesource.com/skia/+/ef59974708dade6fa72fb0218d4f8a9590175c47
==========

[commit-bot: I haz the power, 2016-08-03 22:30:42]

Committed patchset #8 (id:150001) as
https://skia.googlesource.com/skia/+/ef59974708dade6fa72fb0218d4f8a9590175c47

[mtklein, 2016-08-04 02:19:31]

A revert of this CL (patchset #8 id:150001) has been created in
https://codereview.chromium.org/2215433003/ by mtklein@google.com.

The reason for reverting is: missed GrVkPipelineStateCache.

[hal.canary, 2016-08-04 14:17:09]

Description was changed from

==========
SkRTConf: reduce functionality to what we use, increase simplicity

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2212473002
DOCS_PREVIEW= https://skia.org/?cl=2212473002
CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot

[mtklein]
TBR=reed@google.com
Only removing unused public API.

Committed:
https://skia.googlesource.com/skia/+/ef59974708dade6fa72fb0218d4f8a9590175c47
==========

to

==========
SkRTConf: reduce functionality to what we use, increase simplicity

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2212473002
DOCS_PREVIEW= https://skia.org/?cl=2212473002
CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot

[mtklein]
TBR=reed@google.com
Only removing unused public API.

Committed:
https://skia.googlesource.com/skia/+/ef59974708dade6fa72fb0218d4f8a9590175c47
==========

[hal.canary, 2016-08-04 14:17:46]

Description was changed from

==========
SkRTConf: reduce functionality to what we use, increase simplicity

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2212473002
DOCS_PREVIEW= https://skia.org/?cl=2212473002
CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot

[mtklein]
TBR=reed@google.com
Only removing unused public API.

Committed:
https://skia.googlesource.com/skia/+/ef59974708dade6fa72fb0218d4f8a9590175c47
==========

to

==========
SkRTConf: eliminate

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2212473002
DOCS_PREVIEW= https://skia.org/?cl=2212473002
CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot

[mtklein]
TBR=reed@google.com
Only removing unused public API.
==========

[hal.canary, 2016-08-04 14:18:51]

The CQ bit was checked by halcanary@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-04 14:18:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-04 14:37:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-04 14:37:14]

Dry run: This issue passed the CQ dry run.

[mtklein, 2016-08-04 17:09:23]

The CQ bit was checked by mtklein@google.com

[mtklein, 2016-08-04 17:09:23]

The patchset sent to the CQ was uploaded after l-g-t-m from mtklein@google.com
Link to the patchset: https://codereview.chromium.org/2212473002/#ps170001
(title: "`git grep SK_CONF` now returns nothing")

[commit-bot: I haz the power, 2016-08-04 17:09:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-04 17:47:19]

Description was changed from

==========
SkRTConf: eliminate

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2212473002
DOCS_PREVIEW= https://skia.org/?cl=2212473002
CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot

[mtklein]
TBR=reed@google.com
Only removing unused public API.
==========

to

==========
SkRTConf: eliminate

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2212473002
DOCS_PREVIEW= https://skia.org/?cl=2212473002
CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot

[mtklein]
TBR=reed@google.com
Only removing unused public API.

Committed:
https://skia.googlesource.com/skia/+/4e44efe50474d4eebcb30b762e784b3ef2126750
==========

[commit-bot: I haz the power, 2016-08-04 17:47:20]

Committed patchset #9 (id:170001) as
https://skia.googlesource.com/skia/+/4e44efe50474d4eebcb30b762e784b3ef2126750