Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2213473003: MD Settings: Remove some unhelpful properties (Closed)

Created:
4 years, 4 months ago by michaelpg
Modified:
4 years, 4 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@JustSubpageHidePatch
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Remove some unhelpful properties BUG=none R=dbeam@chromium.org NOPRESUBMIT=true CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/67b8eb267f9a05d645b869e5ab4d945fe3e9a295 Cr-Commit-Position: refs/heads/master@{#409903}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -29 lines) Patch
M chrome/browser/resources/settings/about_page/about_page.js View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/resources/settings/advanced_page/advanced_page.js View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/resources/settings/basic_page/basic_page.html View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/basic_page/basic_page.js View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/resources/settings/settings_page/main_page_behavior.js View 2 chunks +1 line, -7 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 14 (7 generated)
michaelpg
4 years, 4 months ago (2016-08-04 06:13:36 UTC) #2
Dan Beam
lgtm if tests pass and the page still works and stuff
4 years, 4 months ago (2016-08-04 18:00:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2213473003/1
4 years, 4 months ago (2016-08-04 18:12:00 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/231281)
4 years, 4 months ago (2016-08-04 18:20:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2213473003/1
4 years, 4 months ago (2016-08-04 20:35:39 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-04 21:23:16 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-04 21:25:40 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/67b8eb267f9a05d645b869e5ab4d945fe3e9a295
Cr-Commit-Position: refs/heads/master@{#409903}

Powered by Google App Engine
This is Rietveld 408576698