MD Settings: Ensure sections are shown

MD Settings: Ensure sections are shown

A bug in main_page_behavior.js could result in all sections on the page becoming
hidden, e.g. when using the Manage Accessibility page on Chrome OS.

BUG=589681
TBR=dbeam@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/0c4084804897ac45b5ff65a690ec6583b97225c0
Cr-Commit-Position: refs/heads/master@{#409710}

[michaelpg, 2016-08-04 01:06:06]

Description was changed from

==========
MD Settings: Ensure sections are shown

A bug in main_page_behavior.js could result in all sections on the page becoming
hidden, e.g. when using the Manage Accessibility page on Chrome OS.

BUG=589681
R=dbeam@chromium.org
==========

to

==========
MD Settings: Ensure sections are shown

A bug in main_page_behavior.js could result in all sections on the page becoming
hidden, e.g. when using the Manage Accessibility page on Chrome OS.

BUG=589681
R=dbeam@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[michaelpg, 2016-08-04 01:06:30]

Description was changed from

==========
MD Settings: Ensure sections are shown

A bug in main_page_behavior.js could result in all sections on the page becoming
hidden, e.g. when using the Manage Accessibility page on Chrome OS.

BUG=589681
R=dbeam@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Ensure sections are shown

A bug in main_page_behavior.js could result in all sections on the page becoming
hidden, e.g. when using the Manage Accessibility page on Chrome OS.

BUG=589681
TBR=dbeam@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[michaelpg, 2016-08-04 01:06:57]

TBR because this was reviewed already in
https://codereview.chromium.org/2200853002/ but I removed the tests since
they're potentially flaky.

[michaelpg, 2016-08-04 01:07:02]

The CQ bit was checked by michaelpg@chromium.org

[commit-bot: I haz the power, 2016-08-04 01:07:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dan Beam, 2016-08-04 01:10:27]

lgtm

https://codereview.chromium.org/2208333002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/settings_page/main_page_behavior.js
(right):

https://codereview.chromium.org/2208333002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/settings_page/main_page_behavior.js:60:
section.hidden = hidden && (section.section != sectionName);
nit that i didn't bother to previously say: i don't know that these () really
add enough to merit being there, but if you reallly think they add to
readability, sure

[michaelpg, 2016-08-04 01:36:42]

https://codereview.chromium.org/2208333002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/settings_page/main_page_behavior.js
(right):

https://codereview.chromium.org/2208333002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/settings_page/main_page_behavior.js:60:
section.hidden = hidden && (section.section != sectionName);
On 2016/08/04 01:10:27, Dan Beam wrote:
> nit that i didn't bother to previously say: i don't know that these () really
> add enough to merit being there, but if you reallly think they add to
> readability, sure

i'm really stingy with my parens, which used to be a common nit, so I compensate
by using them more. different operators being used together tends to confuse
people

[commit-bot: I haz the power, 2016-08-04 02:53:18]

Description was changed from

==========
MD Settings: Ensure sections are shown

A bug in main_page_behavior.js could result in all sections on the page becoming
hidden, e.g. when using the Manage Accessibility page on Chrome OS.

BUG=589681
TBR=dbeam@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Ensure sections are shown

A bug in main_page_behavior.js could result in all sections on the page becoming
hidden, e.g. when using the Manage Accessibility page on Chrome OS.

BUG=589681
TBR=dbeam@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-08-04 02:53:19]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-04 02:54:55]

Description was changed from

==========
MD Settings: Ensure sections are shown

A bug in main_page_behavior.js could result in all sections on the page becoming
hidden, e.g. when using the Manage Accessibility page on Chrome OS.

BUG=589681
TBR=dbeam@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Ensure sections are shown

A bug in main_page_behavior.js could result in all sections on the page becoming
hidden, e.g. when using the Manage Accessibility page on Chrome OS.

BUG=589681
TBR=dbeam@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/0c4084804897ac45b5ff65a690ec6583b97225c0
Cr-Commit-Position: refs/heads/master@{#409710}
==========

[commit-bot: I haz the power, 2016-08-04 02:54:56]

Patchset 1 (id:??) landed as
https://crrev.com/0c4084804897ac45b5ff65a690ec6583b97225c0
Cr-Commit-Position: refs/heads/master@{#409710}