chrome/browser/resources/settings/advanced_page/advanced_page.js - Issue 2213473003: MD Settings: Remove some unhelpful properties

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/advanced_page/advanced_page.js

Issue 2213473003: MD Settings: Remove some unhelpful properties (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@JustSubpageHidePatch

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/about_page/about_page.js ('k') | chrome/browser/resources/settings/basic_page/basic_page.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/advanced_page/advanced_page.js

diff --git a/chrome/browser/resources/settings/advanced_page/advanced_page.js b/chrome/browser/resources/settings/advanced_page/advanced_page.js

index def015b19a5a1c0afb19fcd2f3d5cb33a42e644a..18e7c814219b99cca5200ec653e325fdd895d560 100644

--- a/chrome/browser/resources/settings/advanced_page/advanced_page.js

+++ b/chrome/browser/resources/settings/advanced_page/advanced_page.js

@@ -30,11 +30,4 @@ Polymer({

notify: true,

- /**

- * @type {string} Selector to get the sections.

- * TODO(michaelpg): replace duplicate docs with @override once b/24294625

- * is fixed.

- */

- sectionSelector: 'settings-section',

});