Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 2207353002: Consolidate some Settings styles (Closed)

Created:
4 years, 4 months ago by michaelpg
Modified:
4 years, 4 months ago
Reviewers:
dschuyler
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@RemoveProperties
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Consolidate some Settings styles It's easier to think about main-page styles in one place. It's also nice for settings-section to not do too much structural styling, defer to the page instead. BUG=none R=dschuyler@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/47a206036c5e92b9ce47ad98829a69df4f852d0a Cr-Commit-Position: refs/heads/master@{#410107}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -24 lines) Patch
M chrome/browser/resources/settings/settings_page/main_page_behavior.html View 1 chunk +0 lines, -18 lines 0 comments Download
M chrome/browser/resources/settings/settings_page/settings_section.html View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/resources/settings/settings_page_css.html View 2 chunks +14 lines, -2 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 14 (7 generated)
michaelpg
4 years, 4 months ago (2016-08-04 06:14:50 UTC) #3
dschuyler
lgtm
4 years, 4 months ago (2016-08-04 18:23:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2207353002/1
4 years, 4 months ago (2016-08-05 05:16:57 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/274865)
4 years, 4 months ago (2016-08-05 06:29:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2207353002/1
4 years, 4 months ago (2016-08-05 17:19:35 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-05 18:03:21 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-05 18:06:32 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/47a206036c5e92b9ce47ad98829a69df4f852d0a
Cr-Commit-Position: refs/heads/master@{#410107}

Powered by Google App Engine
This is Rietveld 408576698