Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5808)

Unified Diff: chrome/browser/resources/settings/settings_page/main_page_behavior.js

Issue 2213473003: MD Settings: Remove some unhelpful properties (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@JustSubpageHidePatch
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/settings/basic_page/basic_page.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/settings_page/main_page_behavior.js
diff --git a/chrome/browser/resources/settings/settings_page/main_page_behavior.js b/chrome/browser/resources/settings/settings_page/main_page_behavior.js
index e17f8809087f41f54231fe9eb93763c45bb28a29..532418a01d4054c21e630a04ccefc4ce8a719018 100644
--- a/chrome/browser/resources/settings/settings_page/main_page_behavior.js
+++ b/chrome/browser/resources/settings/settings_page/main_page_behavior.js
@@ -30,12 +30,6 @@ function doWhenReady(readyTest, readyCallback) {
* @polymerBehavior Polymer.MainPageBehavior
*/
var MainPageBehaviorImpl = {
- /**
- * @type {string} Selector to get the sections. Derived elements
- * must override.
- */
- sectionSelector: '',
-
/** @type {?Element} The scrolling container. */
scroller: null,
@@ -55,7 +49,7 @@ var MainPageBehaviorImpl = {
*/
toggleOtherSectionsHidden_: function(sectionName, hidden) {
var sections = Polymer.dom(this.root).querySelectorAll(
- this.sectionSelector);
+ 'settings-section');
for (var section of sections)
section.hidden = hidden && (section.section != sectionName);
},
« no previous file with comments | « chrome/browser/resources/settings/basic_page/basic_page.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698