Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 221283009: [DevTools] Pass inspected page bounds from frontend. (Closed)

Created:
6 years, 8 months ago by dgozman
Modified:
6 years, 7 months ago
CC:
chromium-reviews, vsevik, yurys, paulirish+reviews_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

[DevTools] Pass inspected page bounds from frontend. Passing bounds instead of insets is a more reliable approach in general, but has disadvantages when resizing the whole browser window (as new bounds are only available after round-trip to DevTools frontend). BUG=373669 TBR=avi@chromium.org // For browser_window_controller_browsertest Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271379

Patch Set 1 #

Patch Set 2 : rebased #

Patch Set 3 : rebased #

Patch Set 4 : rebase #

Patch Set 5 : mac fix #

Patch Set 6 : #

Patch Set 7 : rebase #

Patch Set 8 : Fix test on mac #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -32 lines) Patch
M chrome/browser/devtools/devtools_contents_resizing_strategy.h View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/devtools/devtools_contents_resizing_strategy.cc View 2 chunks +19 lines, -1 line 0 comments Download
M chrome/browser/devtools/devtools_embedder_message_dispatcher.h View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/devtools/devtools_embedder_message_dispatcher.cc View 1 2 3 4 5 2 chunks +19 lines, -2 lines 0 comments Download
M chrome/browser/devtools/devtools_ui_bindings.h View 1 2 3 4 5 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/devtools/devtools_ui_bindings.cc View 1 2 3 4 5 2 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/devtools/devtools_window.h View 1 2 3 4 5 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/devtools/devtools_window.cc View 1 2 3 4 5 6 7 1 chunk +12 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm View 1 2 3 4 5 6 7 2 chunks +4 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 1 2 3 4 5 6 7 1 chunk +4 lines, -8 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
dgozman
Could you please take a look? This patch allows more sophisticated positioning inside DevTools frontend ...
6 years, 7 months ago (2014-05-15 09:40:23 UTC) #1
ccameron
RWHVMac part seems reasonable for now. There's going to be a bit of churn for ...
6 years, 7 months ago (2014-05-15 16:36:10 UTC) #2
dgozman
On 2014/05/15 16:36:10, ccameron1 wrote: > RWHVMac part seems reasonable for now. There's going to ...
6 years, 7 months ago (2014-05-15 16:52:54 UTC) #3
pfeldman
lgtm
6 years, 7 months ago (2014-05-15 18:27:19 UTC) #4
ccameron
On 2014/05/15 18:27:19, pfeldman wrote: > lgtm Sorry, forgot to write lgtm
6 years, 7 months ago (2014-05-16 06:15:28 UTC) #5
dgozman
Tom, take a look at devtools_embedder_message_dispatcher please.
6 years, 7 months ago (2014-05-16 11:21:38 UTC) #6
Tom Sepez
lgtm
6 years, 7 months ago (2014-05-16 19:54:07 UTC) #7
dgozman
The CQ bit was checked by dgozman@chromium.org
6 years, 7 months ago (2014-05-19 08:27:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/221283009/120001
6 years, 7 months ago (2014-05-19 08:27:26 UTC) #9
dgozman
The CQ bit was unchecked by dgozman@chromium.org
6 years, 7 months ago (2014-05-19 11:10:49 UTC) #10
dgozman
The CQ bit was checked by dgozman@chromium.org
6 years, 7 months ago (2014-05-19 11:27:27 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/221283009/140001
6 years, 7 months ago (2014-05-19 11:27:38 UTC) #12
commit-bot: I haz the power
6 years, 7 months ago (2014-05-19 14:51:14 UTC) #13
Message was sent while issue was closed.
Change committed as 271379

Powered by Google App Engine
This is Rietveld 408576698