[DevTools] Pass inspected page bounds from frontend.
Passing bounds instead of insets is a more reliable approach in general, but has disadvantages when resizing the whole browser window (as new bounds are only available after round-trip to DevTools frontend).
BUG=373669TBR=avi@chromium.org // For browser_window_controller_browsertest
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271379
Could you please take a look? This patch allows more sophisticated positioning inside DevTools frontend ...
6 years, 7 months ago
(2014-05-15 09:40:23 UTC)
#1
Could you please take a look?
This patch allows more sophisticated positioning inside DevTools frontend
(required for responsive design work):
- seems to have no visible effect on Aura;
- slightly improves DevTools splitter resize on Mac;
- regresses window resize with open DevTools on Mac (still on par with Aura
though);
- has no effect when DevTools is closed.
Follow-up blink-side patch: https://codereview.chromium.org/223803003/.
ccameron
RWHVMac part seems reasonable for now. There's going to be a bit of churn for ...
6 years, 7 months ago
(2014-05-15 16:36:10 UTC)
#2
RWHVMac part seems reasonable for now. There's going to be a bit of churn for
the next few weeks, but after that we should be able to start polishing a
non-moving target WRT resize behavior etc.
dgozman
On 2014/05/15 16:36:10, ccameron1 wrote: > RWHVMac part seems reasonable for now. There's going to ...
6 years, 7 months ago
(2014-05-15 16:52:54 UTC)
#3
On 2014/05/15 16:36:10, ccameron1 wrote:
> RWHVMac part seems reasonable for now. There's going to be a bit of churn for
> the next few weeks, but after that we should be able to start polishing a
> non-moving target WRT resize behavior etc.
Ok, I'll keep an eye on this. I also need your review as an OWNER of RWHVMac.
pfeldman
lgtm
6 years, 7 months ago
(2014-05-15 18:27:19 UTC)
#4
lgtm
ccameron
On 2014/05/15 18:27:19, pfeldman wrote: > lgtm Sorry, forgot to write lgtm
6 years, 7 months ago
(2014-05-16 06:15:28 UTC)
#5
On 2014/05/15 18:27:19, pfeldman wrote:
> lgtm
Sorry, forgot to write lgtm
dgozman
Tom, take a look at devtools_embedder_message_dispatcher please.
6 years, 7 months ago
(2014-05-16 11:21:38 UTC)
#6
Tom, take a look at devtools_embedder_message_dispatcher please.
Tom Sepez
lgtm
6 years, 7 months ago
(2014-05-16 19:54:07 UTC)
#7
lgtm
dgozman
The CQ bit was checked by dgozman@chromium.org
6 years, 7 months ago
(2014-05-19 08:27:12 UTC)
#8
Issue 221283009: [DevTools] Pass inspected page bounds from frontend.
(Closed)
Created 6 years, 8 months ago by dgozman
Modified 6 years, 7 months ago
Reviewers: pfeldman, ccameron, Tom Sepez
Base URL: https://chromium.googlesource.com/chromium/src.git@master
Comments: 0