chrome/browser/devtools/devtools_ui_bindings.h - Issue 221283009: [DevTools] Pass inspected page bounds from frontend.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/devtools/devtools_ui_bindings.h

Issue 221283009: [DevTools] Pass inspected page bounds from frontend. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix test on mac Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/devtools/devtools_embedder_message_dispatcher.cc ('k') | chrome/browser/devtools/devtools_ui_bindings.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/devtools/devtools_ui_bindings.h

diff --git a/chrome/browser/devtools/devtools_ui_bindings.h b/chrome/browser/devtools/devtools_ui_bindings.h

index f6f2438c146d8a6e3eca1c40f4782b215db93d49..ddf583665a593f68b55ff7e9970c62f910999b49 100644

--- a/chrome/browser/devtools/devtools_ui_bindings.h

+++ b/chrome/browser/devtools/devtools_ui_bindings.h

@@ -47,8 +47,7 @@ class DevToolsUIBindings : public content::NotificationObserver,

virtual ~Delegate() {}

virtual void ActivateWindow() = 0;

virtual void CloseWindow() = 0;

- virtual void SetContentsInsets(

- int left, int top, int right, int bottom) = 0;

+ virtual void SetInspectedPageBounds(const gfx::Rect& rect) = 0;

virtual void SetContentsResizingStrategy(

const gfx::Insets& insets, const gfx::Size& min_size) = 0;

virtual void InspectElementCompleted() = 0;

@@ -91,8 +90,7 @@ class DevToolsUIBindings : public content::NotificationObserver,

// DevToolsEmbedderMessageDispatcher::Delegate overrides:

virtual void ActivateWindow() OVERRIDE;

virtual void CloseWindow() OVERRIDE;

- virtual void SetContentsInsets(

- int left, int top, int right, int bottom) OVERRIDE;

+ virtual void SetInspectedPageBounds(const gfx::Rect& rect) OVERRIDE;

virtual void SetContentsResizingStrategy(

const gfx::Insets& insets, const gfx::Size& min_size) OVERRIDE;

virtual void InspectElementCompleted() OVERRIDE;

« no previous file with comments | « chrome/browser/devtools/devtools_embedder_message_dispatcher.cc ('k') | chrome/browser/devtools/devtools_ui_bindings.cc » ('j') | no next file with comments »