Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(470)

Side by Side Diff: chrome/browser/devtools/devtools_embedder_message_dispatcher.cc

Issue 221283009: [DevTools] Pass inspected page bounds from frontend. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix test on mac Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/devtools/devtools_embedder_message_dispatcher.h" 5 #include "chrome/browser/devtools/devtools_embedder_message_dispatcher.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/values.h" 8 #include "base/values.h"
9 9
10 namespace { 10 namespace {
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
44 return false; 44 return false;
45 int width = 0; 45 int width = 0;
46 int height = 0; 46 int height = 0;
47 if (!dict->GetInteger("width", &width) || 47 if (!dict->GetInteger("width", &width) ||
48 !dict->GetInteger("height", &height)) 48 !dict->GetInteger("height", &height))
49 return false; 49 return false;
50 size.SetSize(width, height); 50 size.SetSize(width, height);
51 return true; 51 return true;
52 } 52 }
53 53
54 bool GetValue(const base::ListValue& list, int pos, gfx::Rect& rect) {
55 const base::DictionaryValue* dict;
56 if (!list.GetDictionary(pos, &dict))
57 return false;
58 int x = 0;
59 int y = 0;
60 int width = 0;
61 int height = 0;
62 if (!dict->GetInteger("x", &x) ||
63 !dict->GetInteger("y", &y) ||
64 !dict->GetInteger("width", &width) ||
65 !dict->GetInteger("height", &height))
66 return false;
67 rect.SetRect(x, y, width, height);
68 return true;
69 }
70
54 template <typename T> 71 template <typename T>
55 struct StorageTraits { 72 struct StorageTraits {
56 typedef T StorageType; 73 typedef T StorageType;
57 }; 74 };
58 75
59 template <typename T> 76 template <typename T>
60 struct StorageTraits<const T&> { 77 struct StorageTraits<const T&> {
61 typedef T StorageType; 78 typedef T StorageType;
62 }; 79 };
63 80
(...skipping 168 matching lines...) Expand 10 before | Expand all | Expand 10 after
232 }; 249 };
233 250
234 251
235 DevToolsEmbedderMessageDispatcher* 252 DevToolsEmbedderMessageDispatcher*
236 DevToolsEmbedderMessageDispatcher::createForDevToolsFrontend( 253 DevToolsEmbedderMessageDispatcher::createForDevToolsFrontend(
237 Delegate* delegate) { 254 Delegate* delegate) {
238 DispatcherImpl* d = new DispatcherImpl(); 255 DispatcherImpl* d = new DispatcherImpl();
239 256
240 d->RegisterHandler("bringToFront", &Delegate::ActivateWindow, delegate); 257 d->RegisterHandler("bringToFront", &Delegate::ActivateWindow, delegate);
241 d->RegisterHandler("closeWindow", &Delegate::CloseWindow, delegate); 258 d->RegisterHandler("closeWindow", &Delegate::CloseWindow, delegate);
242 d->RegisterHandler("setContentsInsets", 259 d->RegisterHandler("setInspectedPageBounds",
243 &Delegate::SetContentsInsets, delegate); 260 &Delegate::SetInspectedPageBounds, delegate);
244 d->RegisterHandler("setContentsResizingStrategy", 261 d->RegisterHandler("setContentsResizingStrategy",
245 &Delegate::SetContentsResizingStrategy, delegate); 262 &Delegate::SetContentsResizingStrategy, delegate);
246 d->RegisterHandler("inspectElementCompleted", 263 d->RegisterHandler("inspectElementCompleted",
247 &Delegate::InspectElementCompleted, delegate); 264 &Delegate::InspectElementCompleted, delegate);
248 d->RegisterHandler("inspectedURLChanged", 265 d->RegisterHandler("inspectedURLChanged",
249 &Delegate::InspectedURLChanged, delegate); 266 &Delegate::InspectedURLChanged, delegate);
250 d->RegisterHandler("moveWindowBy", &Delegate::MoveWindow, delegate); 267 d->RegisterHandler("moveWindowBy", &Delegate::MoveWindow, delegate);
251 d->RegisterHandler("setIsDocked", &Delegate::SetIsDocked, delegate); 268 d->RegisterHandler("setIsDocked", &Delegate::SetIsDocked, delegate);
252 d->RegisterHandler("openInNewTab", &Delegate::OpenInNewTab, delegate); 269 d->RegisterHandler("openInNewTab", &Delegate::OpenInNewTab, delegate);
253 d->RegisterHandler("save", &Delegate::SaveToFile, delegate); 270 d->RegisterHandler("save", &Delegate::SaveToFile, delegate);
(...skipping 13 matching lines...) Expand all
267 d->RegisterHandler("zoomOut", &Delegate::ZoomOut, delegate); 284 d->RegisterHandler("zoomOut", &Delegate::ZoomOut, delegate);
268 d->RegisterHandler("resetZoom", &Delegate::ResetZoom, delegate); 285 d->RegisterHandler("resetZoom", &Delegate::ResetZoom, delegate);
269 d->RegisterHandler("openUrlOnRemoteDeviceAndInspect", 286 d->RegisterHandler("openUrlOnRemoteDeviceAndInspect",
270 &Delegate::OpenUrlOnRemoteDeviceAndInspect, delegate); 287 &Delegate::OpenUrlOnRemoteDeviceAndInspect, delegate);
271 d->RegisterHandler( 288 d->RegisterHandler(
272 "subscribe", &Delegate::Subscribe, delegate); 289 "subscribe", &Delegate::Subscribe, delegate);
273 d->RegisterHandler( 290 d->RegisterHandler(
274 "unsubscribe", &Delegate::Unsubscribe, delegate); 291 "unsubscribe", &Delegate::Unsubscribe, delegate);
275 return d; 292 return d;
276 } 293 }
OLDNEW
« no previous file with comments | « chrome/browser/devtools/devtools_embedder_message_dispatcher.h ('k') | chrome/browser/devtools/devtools_ui_bindings.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698