Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Unified Diff: chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm

Issue 221283009: [DevTools] Pass inspected page bounds from frontend. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix test on mac Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm
diff --git a/chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm b/chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm
index b8620ea8b0d3217e5fef0ddc3b18c3b2edf13f0a..e75d5dc60eca79c1d01769ec125c137c43fc5b18 100644
--- a/chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm
+++ b/chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm
@@ -141,9 +141,9 @@ class BrowserWindowControllerTest : public InProcessBrowserTest {
return height;
}
- void SetDevToolsWindowContentsInsets(
- DevToolsWindow* window, int left, int top, int right, int bottom) {
- window->SetContentsInsets(left, top, right, bottom);
+ void SetDevToolsWindowContentsBounds(
+ DevToolsWindow* window, const gfx::Rect& bounds) {
+ window->SetInspectedPageBounds(bounds);
}
private:
@@ -375,7 +375,7 @@ IN_PROC_BROWSER_TEST_F(BrowserWindowControllerTest,
DevToolsWindow* devtools_window = DevToolsWindow::OpenDevToolsWindowForTest(
browser(), true);
- SetDevToolsWindowContentsInsets(devtools_window, 10, 10, 10, 10);
+ SetDevToolsWindowContentsBounds(devtools_window, gfx::Rect(10, 10, 100, 100));
NSPoint originWithDevTools = [controller() statusBubbleBaseFrame].origin;
EXPECT_FALSE(NSEqualPoints(origin, originWithDevTools));
« no previous file with comments | « chrome/browser/devtools/devtools_window.cc ('k') | content/browser/renderer_host/render_widget_host_view_mac.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698