Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2774)

Unified Diff: chrome/browser/devtools/devtools_embedder_message_dispatcher.cc

Issue 221283009: [DevTools] Pass inspected page bounds from frontend. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix test on mac Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/devtools/devtools_embedder_message_dispatcher.cc
diff --git a/chrome/browser/devtools/devtools_embedder_message_dispatcher.cc b/chrome/browser/devtools/devtools_embedder_message_dispatcher.cc
index c71b5a66db78ab628b24329e0b8945c2ec9f503f..5c6db4b9035109fcf2f9f9c0b0041e7c8810cb3b 100644
--- a/chrome/browser/devtools/devtools_embedder_message_dispatcher.cc
+++ b/chrome/browser/devtools/devtools_embedder_message_dispatcher.cc
@@ -51,6 +51,23 @@ bool GetValue(const base::ListValue& list, int pos, gfx::Size& size) {
return true;
}
+bool GetValue(const base::ListValue& list, int pos, gfx::Rect& rect) {
+ const base::DictionaryValue* dict;
+ if (!list.GetDictionary(pos, &dict))
+ return false;
+ int x = 0;
+ int y = 0;
+ int width = 0;
+ int height = 0;
+ if (!dict->GetInteger("x", &x) ||
+ !dict->GetInteger("y", &y) ||
+ !dict->GetInteger("width", &width) ||
+ !dict->GetInteger("height", &height))
+ return false;
+ rect.SetRect(x, y, width, height);
+ return true;
+}
+
template <typename T>
struct StorageTraits {
typedef T StorageType;
@@ -239,8 +256,8 @@ DevToolsEmbedderMessageDispatcher*
d->RegisterHandler("bringToFront", &Delegate::ActivateWindow, delegate);
d->RegisterHandler("closeWindow", &Delegate::CloseWindow, delegate);
- d->RegisterHandler("setContentsInsets",
- &Delegate::SetContentsInsets, delegate);
+ d->RegisterHandler("setInspectedPageBounds",
+ &Delegate::SetInspectedPageBounds, delegate);
d->RegisterHandler("setContentsResizingStrategy",
&Delegate::SetContentsResizingStrategy, delegate);
d->RegisterHandler("inspectElementCompleted",
« no previous file with comments | « chrome/browser/devtools/devtools_embedder_message_dispatcher.h ('k') | chrome/browser/devtools/devtools_ui_bindings.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698