Remove the GetStatus() call from SavePageRequest.

Remove the GetStatus() call from SavePageRequest.
We are moving to a new system of storing a status field.  This removes
code associated with the old way.

BUG=610521
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/ae875419ff203324cd94c335695a7f9c0081e197
Cr-Commit-Position: refs/heads/master@{#410227}

[Pete Williamson, 2016-08-03 23:15:06]

petewil@chromium.org changed reviewers:
+ chili@chromium.org, fgorski@chromium.org

[chili, 2016-08-04 00:14:06]

To make sure we don't break closure, can you update the typedef here?
https://cs.chromium.org/chromium/src/chrome/browser/resources/offline_pages/o...

Also, the internals page currently explicitly shows status
(https://cs.chromium.org/chromium/src/chrome/browser/resources/offline_pages/o...)
You might want to remove that from the HTML and JS
(https://cs.chromium.org/chromium/src/chrome/browser/resources/offline_pages/o...)

[dougarnett, 2016-08-04 00:15:05]

dougarnett@chromium.org changed reviewers:
+ dougarnett@chromium.org

[dougarnett, 2016-08-04 00:15:05]

lgtm

[Pete Williamson, 2016-08-04 00:20:36]

On 2016/08/04 00:14:06, chili wrote:
> To make sure we don't break closure, can you update the typedef here?
>
https://cs.chromium.org/chromium/src/chrome/browser/resources/offline_pages/o...
> 
> Also, the internals page currently explicitly shows status
>
(https://cs.chromium.org/chromium/src/chrome/browser/resources/offline_pages/o...)
> You might want to remove that from the HTML and JS
>
(https://cs.chromium.org/chromium/src/chrome/browser/resources/offline_pages/o...)

Status is about to return, but in a different form.  So, my plan is to leave the
status field blank for now, and put a value back into it early next week.  Is
that OK, or would you prefer that I remove the field in the meantime?

[dougarnett, 2016-08-04 00:26:33]

On 2016/08/04 00:20:36, Pete Williamson wrote:
> On 2016/08/04 00:14:06, chili wrote:
> > To make sure we don't break closure, can you update the typedef here?
> >
>
https://cs.chromium.org/chromium/src/chrome/browser/resources/offline_pages/o...
> > 
> > Also, the internals page currently explicitly shows status
> >
>
(https://cs.chromium.org/chromium/src/chrome/browser/resources/offline_pages/o...)
> > You might want to remove that from the HTML and JS
> >
>
(https://cs.chromium.org/chromium/src/chrome/browser/resources/offline_pages/o...)
> 
> Status is about to return, but in a different form.  So, my plan is to leave
the
> status field blank for now, and put a value back into it early next week.  Is
> that OK, or would you prefer that I remove the field in the meantime?

You could populate it with a hard coded "Available" for now maybe

[chili, 2016-08-04 00:46:37]

On 2016/08/04 00:26:33, dougarnett wrote:
> On 2016/08/04 00:20:36, Pete Williamson wrote:
> > On 2016/08/04 00:14:06, chili wrote:
> > > To make sure we don't break closure, can you update the typedef here?
> > >
> >
>
https://cs.chromium.org/chromium/src/chrome/browser/resources/offline_pages/o...
> > > 
> > > Also, the internals page currently explicitly shows status
> > >
> >
>
(https://cs.chromium.org/chromium/src/chrome/browser/resources/offline_pages/o...)
> > > You might want to remove that from the HTML and JS
> > >
> >
>
(https://cs.chromium.org/chromium/src/chrome/browser/resources/offline_pages/o...)
> > 
> > Status is about to return, but in a different form.  So, my plan is to leave
> the
> > status field blank for now, and put a value back into it early next week. 
Is
> > that OK, or would you prefer that I remove the field in the meantime?
> 
> You could populate it with a hard coded "Available" for now maybe

Yes, I would vote for hard coding it to some string (or even setting to empty
string).  Not having it at all means the page might not render properly (with
closure, and calling <obj>.status errors out with 'no such method')

[Pete Williamson, 2016-08-04 00:56:47]

Description was changed from

==========
Remove the GetStatus() call from SavePageRequest.
We are moving to a new system of storing a status field.  This removes
code associated with the old way.

BUG=610521
==========

to

==========
Remove the GetStatus() call from SavePageRequest.
We are moving to a new system of storing a status field.  This removes
code associated with the old way.

BUG=610521
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Pete Williamson, 2016-08-04 00:57:52]

Added string hardcoded to Available, changed definition for Closure.

[chili, 2016-08-04 01:25:47]

lgtm with minor comment

sorry about the confusion!

https://codereview.chromium.org/2209993002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/offline_pages/offline_internals_browser_proxy.js
(left):

https://codereview.chromium.org/2209993002/diff/20001/chrome/browser/resource...
chrome/browser/resources/offline_pages/offline_internals_browser_proxy.js:22: * 
 status: string,
Oh, sorry... if you're going to leave status as is, you will want to keep this
line.  I suggested to remove this if we were going to remove everything

(the change as is will make the closure compiler fail)

[Pete Williamson, 2016-08-04 16:56:43]

The CQ bit was checked by petewil@chromium.org

[Pete Williamson, 2016-08-04 16:56:43]

The patchset sent to the CQ was uploaded after l-g-t-m from
dougarnett@chromium.org, chili@chromium.org
Link to the patchset: https://codereview.chromium.org/2209993002/#ps40001
(title: "Undo the fix for closure since we put status back.")

[commit-bot: I haz the power, 2016-08-04 16:57:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fgorski, 2016-08-04 16:59:02]

lgtm

[commit-bot: I haz the power, 2016-08-04 17:07:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-04 17:07:19]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Pete Williamson, 2016-08-04 17:19:52]

petewil@chromium.org changed reviewers:
+ bauerb@chromium.org

[Pete Williamson, 2016-08-04 17:19:53]

+bauerb - Please look at changes to offline_internals_ui.cc

[Bernhard Bauer, 2016-08-05 08:37:22]

lgtm

[Pete Williamson, 2016-08-05 22:49:45]

The CQ bit was checked by petewil@chromium.org

[commit-bot: I haz the power, 2016-08-05 22:50:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-05 23:32:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-05 23:32:28]

Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Pete Williamson, 2016-08-05 23:40:20]

The CQ bit was checked by petewil@chromium.org

[commit-bot: I haz the power, 2016-08-05 23:40:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-06 00:25:49]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-06 00:29:05]

Description was changed from

==========
Remove the GetStatus() call from SavePageRequest.
We are moving to a new system of storing a status field.  This removes
code associated with the old way.

BUG=610521
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Remove the GetStatus() call from SavePageRequest.
We are moving to a new system of storing a status field.  This removes
code associated with the old way.

BUG=610521
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/ae875419ff203324cd94c335695a7f9c0081e197
Cr-Commit-Position: refs/heads/master@{#410227}
==========

[commit-bot: I haz the power, 2016-08-06 00:29:06]

Patchset 3 (id:??) landed as
https://crrev.com/ae875419ff203324cd94c335695a7f9c0081e197
Cr-Commit-Position: refs/heads/master@{#410227}