Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Unified Diff: components/offline_pages/background/save_page_request_unittest.cc

Issue 2209993002: Remove the GetStatus() call from SavePageRequest. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Undo the fix for closure since we put status back. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/offline_pages/background/save_page_request.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/offline_pages/background/save_page_request_unittest.cc
diff --git a/components/offline_pages/background/save_page_request_unittest.cc b/components/offline_pages/background/save_page_request_unittest.cc
index 63b970f2e0fa09268472f0aa855ef242effb7118..57fa306285c0c80ad9ca5d7c81616639482640ad 100644
--- a/components/offline_pages/background/save_page_request_unittest.cc
+++ b/components/offline_pages/background/save_page_request_unittest.cc
@@ -33,32 +33,6 @@ TEST_F(SavePageRequestTest, CreatePendingReqeust) {
ASSERT_EQ(creation_time, request.activation_time());
ASSERT_EQ(base::Time(), request.last_attempt_time());
ASSERT_EQ(0, request.attempt_count());
-
- base::Time after_creation = creation_time + base::TimeDelta::FromHours(6);
- ASSERT_EQ(SavePageRequest::Status::PENDING,
- request.GetStatus(after_creation));
-}
-
-TEST_F(SavePageRequestTest, CreateNotReadyRequest) {
- base::Time creation_time = base::Time::Now();
- base::Time activation_time = creation_time + base::TimeDelta::FromHours(6);
- SavePageRequest request(kRequestId, kUrl, kClientId, creation_time,
- activation_time, kUserRequested);
-
- ASSERT_EQ(kRequestId, request.request_id());
- ASSERT_EQ(kUrl, request.url());
- ASSERT_EQ(kClientId, request.client_id());
- ASSERT_EQ(creation_time, request.creation_time());
- ASSERT_EQ(activation_time, request.activation_time());
- ASSERT_EQ(base::Time(), request.last_attempt_time());
- ASSERT_EQ(0, request.attempt_count());
-
- base::Time not_ready_time = activation_time - base::TimeDelta::FromHours(3);
- ASSERT_EQ(SavePageRequest::Status::NOT_READY,
- request.GetStatus(not_ready_time));
-
- base::Time ready_time = activation_time + base::TimeDelta::FromHours(3);
- ASSERT_EQ(SavePageRequest::Status::PENDING, request.GetStatus(ready_time));
}
TEST_F(SavePageRequestTest, StartAndCompleteRequest) {
@@ -81,8 +55,6 @@ TEST_F(SavePageRequestTest, StartAndCompleteRequest) {
ASSERT_EQ(start_time, request.last_attempt_time());
ASSERT_EQ(1, request.attempt_count());
- ASSERT_EQ(SavePageRequest::Status::STARTED, request.GetStatus(start_time));
-
request.MarkAttemptCompleted();
// Again, most things don't change about the request.
@@ -95,7 +67,6 @@ TEST_F(SavePageRequestTest, StartAndCompleteRequest) {
// Last attempt time, status and attempt count are updated.
ASSERT_EQ(base::Time(), request.last_attempt_time());
ASSERT_EQ(1, request.attempt_count());
- ASSERT_EQ(SavePageRequest::Status::PENDING, request.GetStatus(start_time));
}
} // offline_pages
« no previous file with comments | « components/offline_pages/background/save_page_request.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698