Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(544)

Unified Diff: components/offline_pages/background/save_page_request.h

Issue 2209993002: Remove the GetStatus() call from SavePageRequest. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Undo the fix for closure since we put status back. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/background/save_page_request.h
diff --git a/components/offline_pages/background/save_page_request.h b/components/offline_pages/background/save_page_request.h
index 8c09562fa791eaaef8b1cf41d4e2fb49b40f7655..70b2e8c20ac2aa92cee9da7a832677c77f14d434 100644
--- a/components/offline_pages/background/save_page_request.h
+++ b/components/offline_pages/background/save_page_request.h
@@ -16,17 +16,6 @@ namespace offline_pages {
// Class representing a request to save page.
class SavePageRequest {
public:
- enum class Status {
- NOT_READY, // Component requested a page be saved, but not until
- // |activation_time_|.
- PENDING, // Page request is pending, and coordinator can attempt it
- // when it gets a chance to.
- STARTED, // The request is currently being processed.
- FAILED, // Page request failed many times and will no longer be
- // retried.
- EXPIRED, // Save page request expired without being fulfilled.
- };
-
SavePageRequest(int64_t request_id,
const GURL& url,
const ClientId& client_id,
@@ -41,9 +30,6 @@ class SavePageRequest {
SavePageRequest(const SavePageRequest& other);
~SavePageRequest();
- // Status of this request.
- Status GetStatus(const base::Time& now) const;
-
// Updates the |last_attempt_time_| and increments |attempt_count_|.
void MarkAttemptStarted(const base::Time& start_time);
« no previous file with comments | « chrome/browser/ui/webui/offline_internals_ui.cc ('k') | components/offline_pages/background/save_page_request.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698