Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Side by Side Diff: components/offline_pages/background/save_page_request_unittest.cc

Issue 2209993002: Remove the GetStatus() call from SavePageRequest. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Undo the fix for closure since we put status back. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/offline_pages/background/save_page_request.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/offline_pages/background/save_page_request.h" 5 #include "components/offline_pages/background/save_page_request.h"
6 6
7 #include "testing/gtest/include/gtest/gtest.h" 7 #include "testing/gtest/include/gtest/gtest.h"
8 8
9 namespace offline_pages { 9 namespace offline_pages {
10 10
(...skipping 15 matching lines...) Expand all
26 base::Time creation_time = base::Time::Now(); 26 base::Time creation_time = base::Time::Now();
27 SavePageRequest request( 27 SavePageRequest request(
28 kRequestId, kUrl, kClientId, creation_time, kUserRequested); 28 kRequestId, kUrl, kClientId, creation_time, kUserRequested);
29 ASSERT_EQ(kRequestId, request.request_id()); 29 ASSERT_EQ(kRequestId, request.request_id());
30 ASSERT_EQ(kUrl, request.url()); 30 ASSERT_EQ(kUrl, request.url());
31 ASSERT_EQ(kClientId, request.client_id()); 31 ASSERT_EQ(kClientId, request.client_id());
32 ASSERT_EQ(creation_time, request.creation_time()); 32 ASSERT_EQ(creation_time, request.creation_time());
33 ASSERT_EQ(creation_time, request.activation_time()); 33 ASSERT_EQ(creation_time, request.activation_time());
34 ASSERT_EQ(base::Time(), request.last_attempt_time()); 34 ASSERT_EQ(base::Time(), request.last_attempt_time());
35 ASSERT_EQ(0, request.attempt_count()); 35 ASSERT_EQ(0, request.attempt_count());
36
37 base::Time after_creation = creation_time + base::TimeDelta::FromHours(6);
38 ASSERT_EQ(SavePageRequest::Status::PENDING,
39 request.GetStatus(after_creation));
40 }
41
42 TEST_F(SavePageRequestTest, CreateNotReadyRequest) {
43 base::Time creation_time = base::Time::Now();
44 base::Time activation_time = creation_time + base::TimeDelta::FromHours(6);
45 SavePageRequest request(kRequestId, kUrl, kClientId, creation_time,
46 activation_time, kUserRequested);
47
48 ASSERT_EQ(kRequestId, request.request_id());
49 ASSERT_EQ(kUrl, request.url());
50 ASSERT_EQ(kClientId, request.client_id());
51 ASSERT_EQ(creation_time, request.creation_time());
52 ASSERT_EQ(activation_time, request.activation_time());
53 ASSERT_EQ(base::Time(), request.last_attempt_time());
54 ASSERT_EQ(0, request.attempt_count());
55
56 base::Time not_ready_time = activation_time - base::TimeDelta::FromHours(3);
57 ASSERT_EQ(SavePageRequest::Status::NOT_READY,
58 request.GetStatus(not_ready_time));
59
60 base::Time ready_time = activation_time + base::TimeDelta::FromHours(3);
61 ASSERT_EQ(SavePageRequest::Status::PENDING, request.GetStatus(ready_time));
62 } 36 }
63 37
64 TEST_F(SavePageRequestTest, StartAndCompleteRequest) { 38 TEST_F(SavePageRequestTest, StartAndCompleteRequest) {
65 base::Time creation_time = base::Time::Now(); 39 base::Time creation_time = base::Time::Now();
66 base::Time activation_time = creation_time + base::TimeDelta::FromHours(6); 40 base::Time activation_time = creation_time + base::TimeDelta::FromHours(6);
67 SavePageRequest request(kRequestId, kUrl, kClientId, creation_time, 41 SavePageRequest request(kRequestId, kUrl, kClientId, creation_time,
68 activation_time, kUserRequested); 42 activation_time, kUserRequested);
69 43
70 base::Time start_time = activation_time + base::TimeDelta::FromHours(3); 44 base::Time start_time = activation_time + base::TimeDelta::FromHours(3);
71 request.MarkAttemptStarted(start_time); 45 request.MarkAttemptStarted(start_time);
72 46
73 // Most things don't change about the request. 47 // Most things don't change about the request.
74 ASSERT_EQ(kRequestId, request.request_id()); 48 ASSERT_EQ(kRequestId, request.request_id());
75 ASSERT_EQ(kUrl, request.url()); 49 ASSERT_EQ(kUrl, request.url());
76 ASSERT_EQ(kClientId, request.client_id()); 50 ASSERT_EQ(kClientId, request.client_id());
77 ASSERT_EQ(creation_time, request.creation_time()); 51 ASSERT_EQ(creation_time, request.creation_time());
78 ASSERT_EQ(activation_time, request.activation_time()); 52 ASSERT_EQ(activation_time, request.activation_time());
79 53
80 // Attempt time, attempt count and status will though. 54 // Attempt time, attempt count and status will though.
81 ASSERT_EQ(start_time, request.last_attempt_time()); 55 ASSERT_EQ(start_time, request.last_attempt_time());
82 ASSERT_EQ(1, request.attempt_count()); 56 ASSERT_EQ(1, request.attempt_count());
83 57
84 ASSERT_EQ(SavePageRequest::Status::STARTED, request.GetStatus(start_time));
85
86 request.MarkAttemptCompleted(); 58 request.MarkAttemptCompleted();
87 59
88 // Again, most things don't change about the request. 60 // Again, most things don't change about the request.
89 ASSERT_EQ(kRequestId, request.request_id()); 61 ASSERT_EQ(kRequestId, request.request_id());
90 ASSERT_EQ(kUrl, request.url()); 62 ASSERT_EQ(kUrl, request.url());
91 ASSERT_EQ(kClientId, request.client_id()); 63 ASSERT_EQ(kClientId, request.client_id());
92 ASSERT_EQ(creation_time, request.creation_time()); 64 ASSERT_EQ(creation_time, request.creation_time());
93 ASSERT_EQ(activation_time, request.activation_time()); 65 ASSERT_EQ(activation_time, request.activation_time());
94 66
95 // Last attempt time, status and attempt count are updated. 67 // Last attempt time, status and attempt count are updated.
96 ASSERT_EQ(base::Time(), request.last_attempt_time()); 68 ASSERT_EQ(base::Time(), request.last_attempt_time());
97 ASSERT_EQ(1, request.attempt_count()); 69 ASSERT_EQ(1, request.attempt_count());
98 ASSERT_EQ(SavePageRequest::Status::PENDING, request.GetStatus(start_time));
99 } 70 }
100 71
101 } // offline_pages 72 } // offline_pages
OLDNEW
« no previous file with comments | « components/offline_pages/background/save_page_request.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698