Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1432)

Unified Diff: components/offline_pages/background/save_page_request.cc

Issue 2209993002: Remove the GetStatus() call from SavePageRequest. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Undo the fix for closure since we put status back. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/background/save_page_request.cc
diff --git a/components/offline_pages/background/save_page_request.cc b/components/offline_pages/background/save_page_request.cc
index f9372f340a47373ef44a7cb5940d925d810265e5..88a23531f8a0b00ec10d757227a1b855b0c7cd57 100644
--- a/components/offline_pages/background/save_page_request.cc
+++ b/components/offline_pages/background/save_page_request.cc
@@ -45,26 +45,6 @@ SavePageRequest::SavePageRequest(const SavePageRequest& other)
SavePageRequest::~SavePageRequest() {}
-// TODO(fgorski): Introduce policy parameter, once policy is available.
-SavePageRequest::Status SavePageRequest::GetStatus(
- const base::Time& now) const {
- if (now < activation_time_)
- return Status::NOT_READY;
-
- // TODO(fgorski): enable check once policy available.
- // if (attempt_count_ >= policy.max_attempt_count)
- // return Status::FAILED;
-
- // TODO(fgorski): enable check once policy available.
- // if (activation_time_+ policy.page_expiration_interval < now)
- // return Status::EXPIRED;
-
- if (creation_time_ < last_attempt_time_)
- return Status::STARTED;
-
- return Status::PENDING;
-}
-
void SavePageRequest::MarkAttemptStarted(const base::Time& start_time) {
DCHECK_LE(activation_time_, start_time);
// TODO(fgorski): As part of introducing policy in GetStatus, we can make a

Powered by Google App Engine
This is Rietveld 408576698