[recipes] Stop pretending that buildbot_spec is a step, simplify

[recipes] Stop pretending that buildbot_spec is a step, simplify

Since we no longer have to call out to obtain the buildbot_spec, merge
the two functions in vars API.  As a side effect, this applies
default_env to the sync steps as well, which shouldn't have an
appreciable effect on bot behavior.

BUG=skia:5578
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2209343002

Committed: https://skia.googlesource.com/skia/+/c7233ef925157d0c881a1caebe7836e3823c88d5

[borenet2, 2016-08-04 15:11:16]

Description was changed from

==========
[recipes] Stop pretending that buildbot_spec is a step, simplify

Since we no longer have to call out to obtain the buildbot_spec, merge
the two functions in vars API.  As a side effect, this applies
default_env to the sync steps as well, which shouldn't have an
appreciable effect on bot behavior.

BUG=skia:5578
==========

to

==========
[recipes] Stop pretending that buildbot_spec is a step, simplify

Since we no longer have to call out to obtain the buildbot_spec, merge
the two functions in vars API.  As a side effect, this applies
default_env to the sync steps as well, which shouldn't have an
appreciable effect on bot behavior.

BUG=skia:5578
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2209343002
==========

[borenet, 2016-08-04 15:11:56]

borenet@google.com changed reviewers:
+ borenet@google.com, rmistry@google.com

[rmistry, 2016-08-04 17:18:55]

lgtm

[borenet, 2016-08-04 18:08:25]

The CQ bit was checked by borenet@google.com

[borenet, 2016-08-04 18:08:25]

The patchset sent to the CQ was uploaded after l-g-t-m from rmistry@google.com
Link to the patchset: https://codereview.chromium.org/2209343002/#ps20001
(title: "rebase")

[commit-bot: I haz the power, 2016-08-04 18:08:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-04 18:33:04]

Description was changed from

==========
[recipes] Stop pretending that buildbot_spec is a step, simplify

Since we no longer have to call out to obtain the buildbot_spec, merge
the two functions in vars API.  As a side effect, this applies
default_env to the sync steps as well, which shouldn't have an
appreciable effect on bot behavior.

BUG=skia:5578
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2209343002
==========

to

==========
[recipes] Stop pretending that buildbot_spec is a step, simplify

Since we no longer have to call out to obtain the buildbot_spec, merge
the two functions in vars API.  As a side effect, this applies
default_env to the sync steps as well, which shouldn't have an
appreciable effect on bot behavior.

BUG=skia:5578
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2209343002

Committed:
https://skia.googlesource.com/skia/+/c7233ef925157d0c881a1caebe7836e3823c88d5
==========

[commit-bot: I haz the power, 2016-08-04 18:33:05]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/c7233ef925157d0c881a1caebe7836e3823c88d5