infra/bots/recipes/swarm_RecreateSKPs.expected/Housekeeper-Nightly-RecreateSKPs_Canary.json - Issue 2209343002: [recipes] Stop pretending that buildbot_spec is a step, simplify

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: infra/bots/recipes/swarm_RecreateSKPs.expected/Housekeeper-Nightly-RecreateSKPs_Canary.json

Issue 2209343002: [recipes] Stop pretending that buildbot_spec is a step, simplify (Closed) Base URL: https://skia.googlesource.com/skia.git@merge_buildbot_spec_sub1

Patch Set: rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « infra/bots/recipe_modules/vars/api.py ('k') | infra/bots/recipes/swarm_RecreateSKPs.expected/Housekeeper-Weekly-RecreateSKPs.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: infra/bots/recipes/swarm_RecreateSKPs.expected/Housekeeper-Nightly-RecreateSKPs_Canary.json

diff --git a/infra/bots/recipes/swarm_RecreateSKPs.expected/Housekeeper-Nightly-RecreateSKPs_Canary.json b/infra/bots/recipes/swarm_RecreateSKPs.expected/Housekeeper-Nightly-RecreateSKPs_Canary.json

index d04112db7a201dc96b9643f56bab6d0a16c698e1..85779a7e03b94f54fb7c892b60fd42aa532f70ec 100644

--- a/infra/bots/recipes/swarm_RecreateSKPs.expected/Housekeeper-Nightly-RecreateSKPs_Canary.json

+++ b/infra/bots/recipes/swarm_RecreateSKPs.expected/Housekeeper-Nightly-RecreateSKPs_Canary.json

@@ -32,8 +32,11 @@

"cwd": "[CUSTOM_/_B_WORK]",

"env": {

+ "BUILDTYPE": "Release",

"CHROME_HEADLESS": "1",

- "PATH": "%(PATH)s:RECIPE_PACKAGE_REPO[depot_tools]"

+ "GYP_DEFINES": "skia_shared_lib=1 skia_warnings_as_errors=0",

+ "PATH": "%(PATH)s:RECIPE_PACKAGE_REPO[depot_tools]",

+ "SKIA_OUT": "[SLAVE_BUILD]/out"

"name": "gclient setup"

@@ -56,8 +59,11 @@

"cwd": "[CUSTOM_/_B_WORK]",

"env": {

+ "BUILDTYPE": "Release",

"CHROME_HEADLESS": "1",

- "PATH": "%(PATH)s:RECIPE_PACKAGE_REPO[depot_tools]:RECIPE_PACKAGE_REPO[depot_tools]"

+ "GYP_DEFINES": "skia_shared_lib=1 skia_warnings_as_errors=0",

+ "PATH": "%(PATH)s:RECIPE_PACKAGE_REPO[depot_tools]:RECIPE_PACKAGE_REPO[depot_tools]",

+ "SKIA_OUT": "[SLAVE_BUILD]/out"

"name": "gclient sync",

"~followup_annotations": [