[recipes] Stop pretending that buildbot_spec is a step, simplify

infra/bots/recipe_modules/core/api.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 
 # pylint: disable=W0201
 
 
 import json
 import os
 import re
 import sys
 
 from recipe_engine import recipe_api
 from recipe_engine import config_types
 
 
 class SkiaApi(recipe_api.RecipeApi):
 
   def setup(self):
     """Prepare the bot to run."""
     # Setup dependencies.
     self.m.vars.setup()
 
     # Check out the Skia code.
     self.checkout_steps()
 
-    # Obtain the spec for this builder from the Skia repo. Use it to set more
-    # properties.
-    builder_spec = self.m.vars.get_builder_spec(self.m.vars.builder_name)
-
-    # Continue setting up vars with the builder_spec.
-    self.m.vars.update_with_builder_spec(builder_spec)
-
     if not self.m.path.exists(self.m.vars.tmp_dir):
       self.m.run.run_once(self.m.file.makedirs,
                           'tmp_dir',
                           self.m.vars.tmp_dir,
                           infra_step=True)
 
     self.m.flavor.setup()
 
   def update_repo(self, parent_dir, repo):
     """Update an existing repo. This is safe to call without gen_steps."""
@@ skipping 99 matching lines @@
                                           revert=False,
                                           **checkout_kwargs)
 
     self.m.vars.got_revision = (
         update_step.presentation.properties['got_revision'])
     self.m.tryserver.maybe_apply_issue()
 
     if self.m.vars.need_chromium_checkout:
       self.m.gclient.runhooks(cwd=self.m.vars.checkout_root,
                               env=self.m.vars.gclient_env)