Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Unified Diff: infra/bots/recipe_modules/vars/api.py

Issue 2209343002: [recipes] Stop pretending that buildbot_spec is a step, simplify (Closed) Base URL: https://skia.googlesource.com/skia.git@merge_buildbot_spec_sub1
Patch Set: rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: infra/bots/recipe_modules/vars/api.py
diff --git a/infra/bots/recipe_modules/vars/api.py b/infra/bots/recipe_modules/vars/api.py
index 9b3b30333cad00439074c1ebec7a31c3d85dbfcc..897a85a7fc911794decc831656e57e3f44bdace9 100644
--- a/infra/bots/recipe_modules/vars/api.py
+++ b/infra/bots/recipe_modules/vars/api.py
@@ -783,12 +783,8 @@ class SkiaVarsApi(recipe_api.RecipeApi):
# Some bots also require a checkout of PDFium.
self.need_pdfium_checkout = 'PDFium' in self.builder_name
-
- def update_with_builder_spec(self, builder_spec):
- """Set more variables based on the builder_spec."""
- # Obtain the spec for this builder from the Skia repo. Use it to set more
- # properties.
- self.builder_spec = builder_spec
+ # Obtain the spec for this builder. Use it to set more properties.
+ self.builder_spec = get_builder_spec(self.m, self.builder_name)
self.builder_cfg = self.builder_spec['builder_cfg']
self.role = self.builder_cfg['role']

Powered by Google App Engine
This is Rietveld 408576698