Move off SK_SUPPORT_LEGACY_DATA_FACTORIES.

Move off SK_SUPPORT_LEGACY_DATA_FACTORIES.

This moves Skia code off of SK_SUPPORT_LEGACY_DATA_FACTORIES.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2206633004

Committed: https://skia.googlesource.com/skia/+/38d909ec2875f79952de08f36adfaac5680d2c53

[bungeman-skia, 2016-08-02 20:26:21]

Description was changed from

==========
Move off SK_SUPPORT_LEGACY_DATA_FACTORIES.

This moves Skia code off of SK_SUPPORT_LEGACY_DATA_FACTORIES.
==========

to

==========
Move off SK_SUPPORT_LEGACY_DATA_FACTORIES.

This moves Skia code off of SK_SUPPORT_LEGACY_DATA_FACTORIES.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2206633004
==========

[bungeman-skia, 2016-08-02 20:47:33]

The CQ bit was checked by bungeman@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-02 20:47:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-02 20:52:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-02 20:52:25]

Dry run: Try jobs failed on following builders:
  Build-Ubuntu-GCC-x86_64-Release-GN-Trybot on master.client.skia.compile
(JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86...)

[bungeman-skia, 2016-08-02 21:06:05]

The CQ bit was checked by bungeman@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-02 21:06:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bungeman-skia, 2016-08-02 21:06:45]

bungeman@google.com changed reviewers:
+ reed@google.com

[reed1, 2016-08-02 21:11:25]

lgtm w/ question

https://codereview.chromium.org/2206633004/diff/40001/include/core/SkData.h
File include/core/SkData.h (right):

https://codereview.chromium.org/2206633004/diff/40001/include/core/SkData.h#n...
include/core/SkData.h:70: #ifdef SK_SUPPORT_LEGACY_DATA_FACTORIES
why is this guy guarded?

[bungeman-skia, 2016-08-02 21:29:56]

https://codereview.chromium.org/2206633004/diff/40001/include/core/SkData.h
File include/core/SkData.h (right):

https://codereview.chromium.org/2206633004/diff/40001/include/core/SkData.h#n...
include/core/SkData.h:70: #ifdef SK_SUPPORT_LEGACY_DATA_FACTORIES
On 2016/08/02 21:11:25, reed1 wrote:
> why is this guy guarded?

This has caused some rather awkward code in Chromium when they attempted to use
it. It has unexpected and rather surprising meaning.

For example, this will not bind to a 'sk_sp<SkData>' value at all. That would
require the parameter type to be 'const sk_sp<const SkData>&'. But not having
this signature is actually a good thing, because if someone did call this
signature with an sk_sp<SkData> there would be a ref/unref pair at the call
site. However, almost no one actually has an sk_sp<const SkData> since they're
generally considered const (it does have writable_data(), but we generally
assume no one but the creator of the SkData is going to call it). Generally,
taking smart pointers by reference turns out not to work very well.

It turns out there was just one test file that used this at all, and there is
only one very awkward user in Chromium which would be way better off calling the
other 'equals'. If it turns out we really need something like this in the
future, we can see about adding something back that isn't as awkward.

[commit-bot: I haz the power, 2016-08-02 21:31:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-02 21:31:12]

Dry run: This issue passed the CQ dry run.

[bungeman-skia, 2016-08-02 21:39:10]

The CQ bit was checked by bungeman@google.com

[commit-bot: I haz the power, 2016-08-02 21:39:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-02 21:40:52]

Description was changed from

==========
Move off SK_SUPPORT_LEGACY_DATA_FACTORIES.

This moves Skia code off of SK_SUPPORT_LEGACY_DATA_FACTORIES.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2206633004
==========

to

==========
Move off SK_SUPPORT_LEGACY_DATA_FACTORIES.

This moves Skia code off of SK_SUPPORT_LEGACY_DATA_FACTORIES.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2206633004

Committed:
https://skia.googlesource.com/skia/+/38d909ec2875f79952de08f36adfaac5680d2c53
==========

[commit-bot: I haz the power, 2016-08-02 21:40:53]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/38d909ec2875f79952de08f36adfaac5680d2c53