tools/skhello.cpp - Issue 2206633004: Move off SK_SUPPORT_LEGACY_DATA_FACTORIES.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/skhello.cpp

Issue 2206633004: Move off SK_SUPPORT_LEGACY_DATA_FACTORIES. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Gotta catch 'em all. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/skhello.cpp

diff --git a/tools/skhello.cpp b/tools/skhello.cpp

index f7d5b9a00efd1c9f6bf02ca41e2263fa16e20a1f..d1fb96e0ebb0753d54c070e87a553fab4503a704 100644

--- a/tools/skhello.cpp

+++ b/tools/skhello.cpp

@@ -38,8 +38,8 @@ static bool do_surface(int w, int h, const char path[], const char text[],

doDraw(surface->getCanvas(), paint, text);

sk_sp<SkImage> image(surface->makeImageSnapshot());

- SkAutoDataUnref data(image->encode());

- if (nullptr == data.get()) {

+ sk_sp<SkData> data(image->encode());

+ if (!data) {

return false;

}

SkFILEWStream stream(path);