Move off SK_SUPPORT_LEGACY_DATA_FACTORIES.

tools/skdiff_utils.cpp

 /*
  * Copyright 2012 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 #include "skdiff.h"
 #include "skdiff_utils.h"
 #include "SkBitmap.h"
 #include "SkCodec.h"
 #include "SkData.h"
 #include "SkImageEncoder.h"
 #include "SkStream.h"
 #include "SkTypes.h"
 
 #include <memory>
 
 bool are_buffers_equal(SkData* skdata1, SkData* skdata2) {
     if ((nullptr == skdata1) || (nullptr == skdata2)) {
         return false;
     }
     if (skdata1->size() != skdata2->size()) {
         return false;
     }
     return (0 == memcmp(skdata1->data(), skdata2->data(), skdata1->size()));
 }
 
-SkData* read_file(const char* file_path) {
-    SkData* data = SkData::NewFromFileName(file_path);
+sk_sp<SkData> read_file(const char* file_path) {
+    sk_sp<SkData> data(SkData::MakeFromFileName(file_path));
     if (!data) {
         SkDebugf("WARNING: could not open file <%s> for reading\n", file_path);
     }
     return data;
 }
 
 bool get_bitmap(SkData* fileBits, DiffResource& resource, bool sizeOnly) {
     SkAutoTDelete<SkCodec> codec(SkCodec::NewFromData(fileBits));
     if (!codec) {
         SkDebugf("ERROR: could not create codec for <%s>\n", resource.fFullPath.c_str());
@@ skipping 130 matching lines @@
                 drp->fDifference.fStatus = DiffResource::kDoesNotExist_Status;
             }
             if (write_bitmap(drp->fWhite.fFullPath, drp->fWhite.fBitmap)) {
                 drp->fWhite.fStatus = DiffResource::kExists_Status;
             } else {
                 drp->fWhite.fStatus = DiffResource::kDoesNotExist_Status;
             }
         }
     }
 }