tools/skdiff_utils.cpp - Issue 2206633004: Move off SK_SUPPORT_LEGACY_DATA_FACTORIES.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/skdiff_utils.cpp

Issue 2206633004: Move off SK_SUPPORT_LEGACY_DATA_FACTORIES. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Gotta catch 'em all. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/skdiff_utils.cpp

diff --git a/tools/skdiff_utils.cpp b/tools/skdiff_utils.cpp

index 3d4bf7ea9329a29cc068719a9f13b614190c9495..3a377336829ecaf6ff566ac76fd5b6e8d4e78c44 100644

--- a/tools/skdiff_utils.cpp

+++ b/tools/skdiff_utils.cpp

@@ -25,8 +25,8 @@ bool are_buffers_equal(SkData* skdata1, SkData* skdata2) {

return (0 == memcmp(skdata1->data(), skdata2->data(), skdata1->size()));

}

-SkData* read_file(const char* file_path) {

- SkData* data = SkData::NewFromFileName(file_path);

+sk_sp<SkData> read_file(const char* file_path) {

+ sk_sp<SkData> data(SkData::MakeFromFileName(file_path));

if (!data) {

SkDebugf("WARNING: could not open file <%s> for reading\n", file_path);

}