Move NoSideEffectToString to C++

Move NoSideEffectToString to C++

BUG=

Committed: https://crrev.com/d48170dbf57bb70b5be89ed13873434b94f52b49
Cr-Commit-Position: refs/heads/master@{#38289}

[jgruber, 2016-08-02 13:59:38]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-02 13:59:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-02 14:09:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-02 14:09:49]

Dry run: Try jobs failed on following builders:
  v8_win_compile_dbg on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_compile_dbg/builds/2...)

[jgruber, 2016-08-02 14:25:36]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-02 14:25:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jgruber, 2016-08-02 14:36:43]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-02 14:36:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-02 14:56:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-02 14:56:43]

Dry run: Try jobs failed on following builders:
  v8_win64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng/builds/11674)
  v8_win64_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng_triggered/b...)

[jgruber, 2016-08-03 07:11:57]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-03 07:12:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-03 07:35:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-03 07:35:40]

Dry run: This issue passed the CQ dry run.

[jgruber, 2016-08-03 07:36:30]

jgruber@chromium.org changed reviewers:
+ yangguo@chromium.org

[Yang, 2016-08-03 09:13:18]

looking good

https://codereview.chromium.org/2206573002/diff/60001/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/2206573002/diff/60001/src/objects.cc#newcode278
src/objects.cc:278: return isolate->factory()->null_string();
Can we defer to Object::ToString for these cases above?

I wonder whether we have sufficient test coverage for this. Let's use a
DisallowJavascriptExecution scope around this whole function.

https://codereview.chromium.org/2206573002/diff/60001/src/objects.cc#newcode311
src/objects.cc:311: } else if (input->IsSimd128Value()) {
Same for simd

[jgruber, 2016-08-03 10:52:38]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-03 10:52:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-03 11:16:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-03 11:16:54]

Dry run: This issue passed the CQ dry run.

[jgruber, 2016-08-03 11:17:15]

PTAL

https://codereview.chromium.org/2206573002/diff/60001/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/2206573002/diff/60001/src/objects.cc#newcode278
src/objects.cc:278: return isolate->factory()->null_string();
On 2016/08/03 09:13:18, Yang wrote:
> Can we defer to Object::ToString for these cases above?
> 
> I wonder whether we have sufficient test coverage for this. Let's use a
> DisallowJavascriptExecution scope around this whole function.

Done.

https://codereview.chromium.org/2206573002/diff/60001/src/objects.cc#newcode311
src/objects.cc:311: } else if (input->IsSimd128Value()) {
On 2016/08/03 09:13:18, Yang wrote:
> Same for simd

Done.

[Yang, 2016-08-03 12:13:12]

lgtm.

[jgruber, 2016-08-03 12:16:17]

The CQ bit was checked by jgruber@chromium.org

[commit-bot: I haz the power, 2016-08-03 12:16:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-03 12:20:44]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-08-03 12:22:28]

Description was changed from

==========
Move NoSideEffectToString to C++

BUG=
==========

to

==========
Move NoSideEffectToString to C++

BUG=

Committed: https://crrev.com/d48170dbf57bb70b5be89ed13873434b94f52b49
Cr-Commit-Position: refs/heads/master@{#38289}
==========

[commit-bot: I haz the power, 2016-08-03 12:22:29]

Patchset 5 (id:??) landed as
https://crrev.com/d48170dbf57bb70b5be89ed13873434b94f52b49
Cr-Commit-Position: refs/heads/master@{#38289}