Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Side by Side Diff: src/isolate.cc

Issue 2206573002: Move NoSideEffectToString to C++ (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Address comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/heap-symbols.h ('k') | src/js/harmony-simd.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/isolate.h" 5 #include "src/isolate.h"
6 6
7 #include <stdlib.h> 7 #include <stdlib.h>
8 8
9 #include <fstream> // NOLINT(readability/streams) 9 #include <fstream> // NOLINT(readability/streams)
10 #include <sstream> 10 #include <sstream>
(...skipping 957 matching lines...) Expand 10 before | Expand all | Expand 10 after
968 } 968 }
969 969
970 970
971 Object* Isolate::StackOverflow() { 971 Object* Isolate::StackOverflow() {
972 DisallowJavascriptExecution no_js(this); 972 DisallowJavascriptExecution no_js(this);
973 HandleScope scope(this); 973 HandleScope scope(this);
974 974
975 Handle<JSFunction> fun = range_error_function(); 975 Handle<JSFunction> fun = range_error_function();
976 Handle<Object> msg = factory()->NewStringFromAsciiChecked( 976 Handle<Object> msg = factory()->NewStringFromAsciiChecked(
977 MessageTemplate::TemplateString(MessageTemplate::kStackOverflow)); 977 MessageTemplate::TemplateString(MessageTemplate::kStackOverflow));
978 Handle<Object> no_caller;
978 Handle<Object> exception; 979 Handle<Object> exception;
979 ASSIGN_RETURN_FAILURE_ON_EXCEPTION( 980 ASSIGN_RETURN_FAILURE_ON_EXCEPTION(
980 this, exception, 981 this, exception,
981 ErrorUtils::Construct(this, fun, fun, msg, SKIP_NONE, true)); 982 ErrorUtils::Construct(this, fun, fun, msg, SKIP_NONE, no_caller, true));
982 983
983 Throw(*exception, nullptr); 984 Throw(*exception, nullptr);
984 985
985 #ifdef VERIFY_HEAP 986 #ifdef VERIFY_HEAP
986 if (FLAG_verify_heap && FLAG_stress_compaction) { 987 if (FLAG_verify_heap && FLAG_stress_compaction) {
987 heap()->CollectAllGarbage(Heap::kNoGCFlags, "trigger compaction"); 988 heap()->CollectAllGarbage(Heap::kNoGCFlags, "trigger compaction");
988 } 989 }
989 #endif // VERIFY_HEAP 990 #endif // VERIFY_HEAP
990 991
991 return heap()->exception(); 992 return heap()->exception();
(...skipping 2187 matching lines...) Expand 10 before | Expand all | Expand 10 after
3179 // Then check whether this scope intercepts. 3180 // Then check whether this scope intercepts.
3180 if ((flag & intercept_mask_)) { 3181 if ((flag & intercept_mask_)) {
3181 intercepted_flags_ |= flag; 3182 intercepted_flags_ |= flag;
3182 return true; 3183 return true;
3183 } 3184 }
3184 return false; 3185 return false;
3185 } 3186 }
3186 3187
3187 } // namespace internal 3188 } // namespace internal
3188 } // namespace v8 3189 } // namespace v8
OLDNEW
« no previous file with comments | « src/heap-symbols.h ('k') | src/js/harmony-simd.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698