Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2208663002: Clear exceptions in Invoke instead of JSEntryStub (Closed)

Created:
4 years, 4 months ago by jgruber
Modified:
4 years, 4 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@port-no-sideeffect-to-string
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Clear exceptions in Invoke instead of JSEntryStub A corresponding flag was added as well to help us find out what breaks when we do not clear pending exceptions on each JS entry. BUG=5259 Committed: https://crrev.com/cdae865436aa1039154c86baaac98b2b8a118376 Cr-Commit-Position: refs/heads/master@{#38292}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -36 lines) Patch
M src/arm/code-stubs-arm.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/execution.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/flag-definitions.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M src/messages.cc View 1 1 chunk +7 lines, -4 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
jgruber
4 years, 4 months ago (2016-08-03 12:02:59 UTC) #7
Yang
lgtm.
4 years, 4 months ago (2016-08-03 12:08:02 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2208663002/20001
4 years, 4 months ago (2016-08-03 13:02:53 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-03 13:38:50 UTC) #13
commit-bot: I haz the power
4 years, 4 months ago (2016-08-03 13:40:12 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cdae865436aa1039154c86baaac98b2b8a118376
Cr-Commit-Position: refs/heads/master@{#38292}

Powered by Google App Engine
This is Rietveld 408576698