Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2206203002: Move FormatStackTrace to ErrorUtils (Closed)

Created:
4 years, 4 months ago by jgruber
Modified:
4 years, 4 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@port-no-sideeffect-to-string
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Move FormatStackTrace to ErrorUtils BUG= Committed: https://crrev.com/03924dbf904514ee63cf19e89e3d8f9bee76bfb4 Cr-Commit-Position: refs/heads/master@{#38294}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -9 lines) Patch
M src/accessors.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/builtins/builtins-error.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/messages.h View 2 chunks +6 lines, -5 lines 0 comments Download
M src/messages.cc View 1 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
jgruber
4 years, 4 months ago (2016-08-03 11:17:54 UTC) #4
Yang
On 2016/08/03 11:17:54, jgruber wrote: lgtm.
4 years, 4 months ago (2016-08-03 12:13:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2206203002/20001
4 years, 4 months ago (2016-08-03 13:03:13 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-03 13:48:49 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-03 13:50:06 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/03924dbf904514ee63cf19e89e3d8f9bee76bfb4
Cr-Commit-Position: refs/heads/master@{#38294}

Powered by Google App Engine
This is Rietveld 408576698