Move NoSideEffectToString to C++

src/bootstrapper.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/bootstrapper.h"
 
 #include "src/accessors.h"
 #include "src/api-natives.h"
 #include "src/base/ieee754.h"
 #include "src/code-stubs.h"
@@ skipping 985 matching lines @@
   {
     Handle<JSObject> prototype =
         factory->NewJSObject(isolate->object_function(), TENURED);
 
     JSObject::AddProperty(prototype, factory->name_string(), name, DONT_ENUM);
     JSObject::AddProperty(prototype, factory->message_string(),
                           factory->empty_string(), DONT_ENUM);
     JSObject::AddProperty(prototype, factory->constructor_string(), error_fun,
                           DONT_ENUM);
 
-    Handle<JSFunction> to_string_fun =
-        SimpleInstallFunction(prototype, factory->toString_string(),
-                              Builtins::kErrorPrototypeToString, 0, true);
-    to_string_fun->shared()->set_native(true);
+    if (context_index == Context::ERROR_FUNCTION_INDEX) {
+      Handle<JSFunction> to_string_fun =
+          SimpleInstallFunction(prototype, factory->toString_string(),
+                                Builtins::kErrorPrototypeToString, 0, true);
+      to_string_fun->shared()->set_native(true);
+      isolate->native_context()->set_error_to_string(*to_string_fun);
+    } else {
+      DCHECK(context_index != Context::ERROR_FUNCTION_INDEX);
+      DCHECK(isolate->native_context()->error_to_string()->IsJSFunction());
 
-    if (context_index != Context::ERROR_FUNCTION_INDEX) {
+      InstallFunction(prototype, isolate->error_to_string(),
+                      factory->toString_string(), DONT_ENUM);
+
       Handle<JSFunction> global_error = isolate->error_function();
       CHECK(JSReceiver::SetPrototype(error_fun, global_error, false,
                                      Object::THROW_ON_ERROR)
                 .FromMaybe(false));
       CHECK(JSReceiver::SetPrototype(prototype,
                                      handle(global_error->prototype(), isolate),
                                      false, Object::THROW_ON_ERROR)
                 .FromMaybe(false));
     }
 
@@ skipping 1669 matching lines @@
 
       Handle<JSFunction> fun;
       for (const FunctionInfo& info : infos) {
         fun = SimpleInstallFunction(proto, info.name, info.id, 0, true, attrs);
         fun->shared()->set_native(true);
       }
 
       Accessors::FunctionSetPrototype(callsite_fun, proto).Assert();
     }
   }
+
+  {  // -- E r r o r
+    Handle<JSFunction> make_err_fun = InstallFunction(
+        container, "make_generic_error", JS_OBJECT_TYPE, JSObject::kHeaderSize,
+        isolate->initial_object_prototype(), Builtins::kMakeGenericError);
+    make_err_fun->shared()->DontAdaptArguments();
+  }
 }
 
 
 void Bootstrapper::ExportExperimentalFromRuntime(Isolate* isolate,
                                                  Handle<JSObject> container) {
   HandleScope scope(isolate);
 
 #define INITIALIZE_FLAG(FLAG)                                         \
   {                                                                   \
     Handle<String> name =                                             \
@@ skipping 1354 matching lines @@
 }
 
 
 // Called when the top-level V8 mutex is destroyed.
 void Bootstrapper::FreeThreadResources() {
   DCHECK(!IsActive());
 }
 
 }  // namespace internal
 }  // namespace v8