third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h - Issue 2206483002: [DevTools] Add awaitPromise flag for Runtime.callFunctionOn protocol method

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h

Issue 2206483002: [DevTools] Add awaitPromise flag for Runtime.callFunctionOn protocol method (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove-error-string-from-async

Patch Set: rebased Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js ('k') | third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h

diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h b/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h

index 7d1a22c49827c8b1ac4d2d499daf95aaa7813d11..27cafa027e870ab778856f40d775b0c25f853b34 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h

+++ b/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h

@@ -78,7 +78,7 @@ public:

const Maybe<bool>& returnByValue,

const Maybe<bool>& generatePreview,

std::unique_ptr<AwaitPromiseCallback>) override;

- void callFunctionOn(ErrorString*,

+ void callFunctionOn(

const String16& objectId,

const String16& expression,

const Maybe<protocol::Array<protocol::Runtime::CallArgument>>& optionalArguments,

@@ -86,8 +86,8 @@ public:

const Maybe<bool>& returnByValue,

const Maybe<bool>& generatePreview,

const Maybe<bool>& userGesture,

- std::unique_ptr<protocol::Runtime::RemoteObject>* result,

- Maybe<bool>* wasThrown) override;

+ const Maybe<bool>& awaitPromise,

+ std::unique_ptr<CallFunctionOnCallback>) override;

void releaseObject(ErrorString*, const String16& objectId) override;

void getProperties(ErrorString*,

const String16& objectId,