[DevTools] Add awaitPromise flag to Runtime.runScript

[DevTools] Add awaitPromise flag to Runtime.runScript

- added awaitPromise flag,
- added returnByValue and generatePreview flags to align with other evaluate methods,
- marked executionContextId as optional.

BUG=632875
R=dgozman@chromium.org

Committed: https://crrev.com/0ce09555b528b623d9103e77226472af0a7dabeb
Cr-Commit-Position: refs/heads/master@{#409408}

[kozy, 2016-08-02 19:21:51]

Dmitry, please take a look!

[dgozman, 2016-08-02 21:38:08]

Implementation lgtm, only description adjustments.

https://codereview.chromium.org/2203073004/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp
(right):

https://codereview.chromium.org/2203073004/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp:290:
"Result of expression is not a promise",
Result of the evaluation is not a promise

https://codereview.chromium.org/2203073004/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp:541:
callback->sendFailure("Script execution failed");
No script with given id

https://codereview.chromium.org/2203073004/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/v8_inspector/js_protocol.json (right):

https://codereview.chromium.org/2203073004/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/js_protocol.json:301: { "name":
"executionContextId", "$ref": "ExecutionContextId", "optional": true,
"description": "Specifies in which isolated context to perform script run. Each
content script lives in an isolated context and this parameter is used to
specify one of those contexts. If the parameter is omitted or 0 the evaluation
will be performed in the context of the inspected page." }
The part about "or 0" is not true. Could you please update here and in other
places?

https://codereview.chromium.org/2203073004/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/js_protocol.json:321: { "name":
"awaitPromise", "type": "boolean", "optional":true, "description": "Whether
execution should wait for promise to be resolved. If the result of evaluation is
not a Promise, it's considered to be an error." }
style: missing space before colon

[kozy, 2016-08-02 22:18:50]

All done.

https://codereview.chromium.org/2203073004/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp
(right):

https://codereview.chromium.org/2203073004/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp:290:
"Result of expression is not a promise",
On 2016/08/02 21:38:08, dgozman wrote:
> Result of the evaluation is not a promise

Done.

https://codereview.chromium.org/2203073004/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp:541:
callback->sendFailure("Script execution failed");
On 2016/08/02 21:38:08, dgozman wrote:
> No script with given id

Done.

https://codereview.chromium.org/2203073004/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/v8_inspector/js_protocol.json (right):

https://codereview.chromium.org/2203073004/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/js_protocol.json:301: { "name":
"executionContextId", "$ref": "ExecutionContextId", "optional": true,
"description": "Specifies in which isolated context to perform script run. Each
content script lives in an isolated context and this parameter is used to
specify one of those contexts. If the parameter is omitted or 0 the evaluation
will be performed in the context of the inspected page." }
On 2016/08/02 21:38:08, dgozman wrote:
> The part about "or 0" is not true. Could you please update here and in other
> places?

Added or 0 support back, we need it to support some of protocol clients.

https://codereview.chromium.org/2203073004/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/js_protocol.json:321: { "name":
"awaitPromise", "type": "boolean", "optional":true, "description": "Whether
execution should wait for promise to be resolved. If the result of evaluation is
not a Promise, it's considered to be an error." }
On 2016/08/02 21:38:08, dgozman wrote:
> style: missing space before colon

Done.

[kozy, 2016-08-02 22:20:09]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2016-08-02 22:20:09]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2203073004/#ps20001
(title: "a")

[commit-bot: I haz the power, 2016-08-02 22:21:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kozy, 2016-08-02 23:17:43]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2016-08-02 23:17:43]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2203073004/#ps40001
(title: "fixed executionContextId=0")

[kozy, 2016-08-02 23:18:12]

The CQ bit was unchecked by kozyatinskiy@chromium.org

[kozy, 2016-08-02 23:18:17]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2016-08-02 23:18:33]

The CQ bit was checked by kozyatinskiy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-02 23:18:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kozy, 2016-08-02 23:19:15]

Patchset #2 (id:20001) has been deleted

[commit-bot: I haz the power, 2016-08-03 00:49:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-03 00:49:38]

Dry run: This issue passed the CQ dry run.

[kozy, 2016-08-03 00:53:13]

The CQ bit was checked by kozyatinskiy@chromium.org

[commit-bot: I haz the power, 2016-08-03 00:53:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-03 00:57:44]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-08-03 00:59:04]

Description was changed from

==========
[DevTools] Add awaitPromise flag to Runtime.runScript

- added awaitPromise flag,
- added returnByValue and generatePreview flags to align with other evaluate
methods,
- marked executionContextId as optional.

BUG=632875
R=dgozman@chromium.org
==========

to

==========
[DevTools] Add awaitPromise flag to Runtime.runScript

- added awaitPromise flag,
- added returnByValue and generatePreview flags to align with other evaluate
methods,
- marked executionContextId as optional.

BUG=632875
R=dgozman@chromium.org

Committed: https://crrev.com/0ce09555b528b623d9103e77226472af0a7dabeb
Cr-Commit-Position: refs/heads/master@{#409408}
==========

[commit-bot: I haz the power, 2016-08-03 00:59:05]

Patchset 2 (id:??) landed as
https://crrev.com/0ce09555b528b623d9103e77226472af0a7dabeb
Cr-Commit-Position: refs/heads/master@{#409408}