Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(766)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js

Issue 2206483002: [DevTools] Add awaitPromise flag for Runtime.callFunctionOn protocol method (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove-error-string-from-async
Patch Set: rebased Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js b/third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js
index 08191abaa717d63e63dafb58424bb89dd82842d0..f14fe2a5cf282844ba9b5c04389a10385f06c51b 100644
--- a/third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js
+++ b/third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js
@@ -694,7 +694,7 @@ WebInspector.RemoteObjectImpl.prototype = {
var setPropertyValueFunction = "function(a, b) { this[a] = b; }";
var argv = [name, WebInspector.RemoteObject.toCallArgument(result)];
- this._runtimeAgent.callFunctionOn(this._objectId, setPropertyValueFunction, argv, true, undefined, undefined, undefined, propertySetCallback);
+ this._runtimeAgent.callFunctionOn(this._objectId, setPropertyValueFunction, argv, true, undefined, undefined, undefined, undefined, propertySetCallback);
/**
* @param {?Protocol.Error} error
@@ -724,7 +724,7 @@ WebInspector.RemoteObjectImpl.prototype = {
}
var deletePropertyFunction = "function(a) { delete this[a]; return !(a in this); }";
- this._runtimeAgent.callFunctionOn(this._objectId, deletePropertyFunction, [name], true, undefined, undefined, undefined, deletePropertyCallback);
+ this._runtimeAgent.callFunctionOn(this._objectId, deletePropertyFunction, [name], true, undefined, undefined, undefined, undefined, deletePropertyCallback);
/**
* @param {?Protocol.Error} error
@@ -768,7 +768,7 @@ WebInspector.RemoteObjectImpl.prototype = {
callback(this.target().runtimeModel.createRemoteObject(result), wasThrown);
}
- this._runtimeAgent.callFunctionOn(this._objectId, functionDeclaration.toString(), args, true, undefined, undefined, undefined, mycallback.bind(this));
+ this._runtimeAgent.callFunctionOn(this._objectId, functionDeclaration.toString(), args, true, undefined, undefined, undefined, undefined, mycallback.bind(this));
},
/**
@@ -789,7 +789,7 @@ WebInspector.RemoteObjectImpl.prototype = {
callback((error || wasThrown) ? null : result.value);
}
- this._runtimeAgent.callFunctionOn(this._objectId, functionDeclaration.toString(), args, true, true, false, undefined, mycallback);
+ this._runtimeAgent.callFunctionOn(this._objectId, functionDeclaration.toString(), args, true, true, false, undefined, undefined, mycallback);
},
release: function()

Powered by Google App Engine
This is Rietveld 408576698