src/builtins/builtins-error.cc - Issue 2206203002: Move FormatStackTrace to ErrorUtils

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/builtins/builtins-error.cc

Issue 2206203002: Move FormatStackTrace to ErrorUtils (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@port-no-sideeffect-to-string

Patch Set: Rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/builtins/builtins-error.cc

diff --git a/src/builtins/builtins-error.cc b/src/builtins/builtins-error.cc

index d1be5033d82d96831c3b7d6ff3e9ed1e8b7f7472..66293ee9ac0d02c875325cfb2585c6de99b5adc9 100644

--- a/src/builtins/builtins-error.cc

+++ b/src/builtins/builtins-error.cc

@@ -60,7 +60,7 @@ BUILTIN(ErrorCaptureStackTrace) {

Handle<Object> formatted_stack_trace;

ASSIGN_RETURN_FAILURE_ON_EXCEPTION(

isolate, formatted_stack_trace,

- FormatStackTrace(isolate, object, stack_trace));

+ ErrorUtils::FormatStackTrace(isolate, object, stack_trace));

PropertyDescriptor desc;

desc.set_configurable(true);

« no previous file with comments | « src/accessors.cc ('k') | src/messages.h » ('j') | no next file with comments »