Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Unified Diff: src/messages.h

Issue 2206203002: Move FormatStackTrace to ErrorUtils (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@port-no-sideeffect-to-string
Patch Set: Rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/builtins/builtins-error.cc ('k') | src/messages.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/messages.h
diff --git a/src/messages.h b/src/messages.h
index d63621f9d7fdefacb50cb031e29d802e4bb4ba35..32bcc49ecfc1d1a0f08c86a23dd6d5a425c128b5 100644
--- a/src/messages.h
+++ b/src/messages.h
@@ -76,11 +76,6 @@ class CallSite {
uint32_t wasm_func_index_ = static_cast<uint32_t>(-1);
};
-// Formats a textual stack trace from the given structured stack trace.
-// Note that this can call arbitrary JS code through Error.prepareStackTrace.
-MaybeHandle<Object> FormatStackTrace(Isolate* isolate, Handle<JSObject> error,
- Handle<Object> stack_trace);
-
// Determines how stack trace collection skips frames.
enum FrameSkipMode {
// Unconditionally skips the first frame. Used e.g. when the Error constructor
@@ -104,6 +99,12 @@ class ErrorUtils : public AllStatic {
Isolate* isolate, Handle<JSFunction> constructor, int template_index,
Handle<Object> arg0, Handle<Object> arg1, Handle<Object> arg2,
FrameSkipMode mode);
+
+ // Formats a textual stack trace from the given structured stack trace.
+ // Note that this can call arbitrary JS code through Error.prepareStackTrace.
+ static MaybeHandle<Object> FormatStackTrace(Isolate* isolate,
+ Handle<JSObject> error,
+ Handle<Object> stack_trace);
};
class CallSiteUtils : public AllStatic {
« no previous file with comments | « src/builtins/builtins-error.cc ('k') | src/messages.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698