Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(621)

Unified Diff: src/messages.cc

Issue 2206203002: Move FormatStackTrace to ErrorUtils (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@port-no-sideeffect-to-string
Patch Set: Rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/messages.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/messages.cc
diff --git a/src/messages.cc b/src/messages.cc
index 556012a39ad071e59c394d3dcf2704e5df320215..c3a346bb624dd188a5e0a52e7eea0464e1918895 100644
--- a/src/messages.cc
+++ b/src/messages.cc
@@ -586,8 +586,10 @@ class PrepareStackTraceScope {
} // namespace
-MaybeHandle<Object> FormatStackTrace(Isolate* isolate, Handle<JSObject> error,
- Handle<Object> raw_stack) {
+// static
+MaybeHandle<Object> ErrorUtils::FormatStackTrace(Isolate* isolate,
+ Handle<JSObject> error,
+ Handle<Object> raw_stack) {
// Create JS CallSite objects from the raw stack frame array.
Handle<FixedArray> frames;
« no previous file with comments | « src/messages.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698