src/accessors.cc - Issue 2206203002: Move FormatStackTrace to ErrorUtils

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/accessors.cc

Issue 2206203002: Move FormatStackTrace to ErrorUtils (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@port-no-sideeffect-to-string

Patch Set: Rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/accessors.cc

diff --git a/src/accessors.cc b/src/accessors.cc

index ea69b6fd00cd5ff843451986a86f33769bdf83f0..da44151b3edbdd6d4b517e14936aacc83bd0b6fc 100644

--- a/src/accessors.cc

+++ b/src/accessors.cc

@@ -1171,7 +1171,7 @@ void Accessors::ErrorStackGetter(

// property.

Handle<Object> formatted_stack_trace;

- if (!FormatStackTrace(isolate, holder, stack_trace)

+ if (!ErrorUtils::FormatStackTrace(isolate, holder, stack_trace)

.ToHandle(&formatted_stack_trace)) {

isolate->OptionalRescheduleException(false);

return;

« no previous file with comments | « no previous file | src/builtins/builtins-error.cc » ('j') | no next file with comments »