Android: Don't require RegisterNatives if there are none

Android: Don't require RegisterNatives if there are none

Nowadays the calls up to Java are lazily resolved, so
RegisterNatives() actually does again what the name implies.

Allow not calling RegisterNatives() if there are no native methods
by marking it with the 'unused' attribute.

In follow-up patches all references will be removed so that the
generator can stop emiting the NOP functions where there are no
native methods.

This makes it more straightforward to design one-way JNI interfaces.

BUG=603936, 617313, 617324
Committed: https://crrev.com/dbed3229058fc046539cd20cc546a740179d1fc4
Cr-Commit-Position: refs/heads/master@{#409221}

[no sievers, 2016-08-01 21:42:24]

The CQ bit was checked by sievers@chromium.org to run a CQ dry run

[no sievers, 2016-08-01 21:42:33]

Description was changed from

==========
Android: Don't require RegisterNatives if there are none

Nowadays the calls up to Java are lazily resolved, so
RegisterNatives() actually does again what the name implies.

Allow not calling RegisterNatives() if there are no native methods
by marking it with the attribute unused.

In follow-up patches all references will be removed so that the
generator can stop emiting the NOP functions where there are no
native methods.

This makes it more straightforward to design one-way JNI interfaces.

BUG=603936, 617313, 617324
==========

to

==========
Android: Don't require RegisterNatives if there are none

Nowadays the calls up to Java are lazily resolved, so
RegisterNatives() actually does again what the name implies.

Allow not calling RegisterNatives() if there are no native methods
by marking it with the attribute unused.

In follow-up patches all references will be removed so that the
generator can stop emiting the NOP functions where there are no
native methods.

This makes it more straightforward to design one-way JNI interfaces.

BUG=603936, 617313, 617324
==========

[no sievers, 2016-08-01 21:42:33]

sievers@chromium.org changed reviewers:
+ torne@chromium.org

[no sievers, 2016-08-01 21:42:41]

ptal

https://codereview.chromium.org/2204623002/diff/1/base/android/jni_generator/...
File base/android/jni_generator/jni_generator.py (right):

https://codereview.chromium.org/2204623002/diff/1/base/android/jni_generator/...
base/android/jni_generator/jni_generator.py:855: ${REGISTER_NATIVES_SIGNATURE}
__attribute__((unused));
This can only be used on the declaration, not the definition :/

[commit-bot: I haz the power, 2016-08-01 21:42:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[no sievers, 2016-08-01 21:43:18]

Description was changed from

==========
Android: Don't require RegisterNatives if there are none

Nowadays the calls up to Java are lazily resolved, so
RegisterNatives() actually does again what the name implies.

Allow not calling RegisterNatives() if there are no native methods
by marking it with the attribute unused.

In follow-up patches all references will be removed so that the
generator can stop emiting the NOP functions where there are no
native methods.

This makes it more straightforward to design one-way JNI interfaces.

BUG=603936, 617313, 617324
==========

to

==========
Android: Don't require RegisterNatives if there are none

Nowadays the calls up to Java are lazily resolved, so
RegisterNatives() actually does again what the name implies.

Allow not calling RegisterNatives() if there are no native methods
by marking it with the 'unused' attribute.

In follow-up patches all references will be removed so that the
generator can stop emiting the NOP functions where there are no
native methods.

This makes it more straightforward to design one-way JNI interfaces.

BUG=603936, 617313, 617324
==========

[commit-bot: I haz the power, 2016-08-01 22:58:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-01 22:58:32]

Dry run: This issue passed the CQ dry run.

[Torne, 2016-08-02 12:23:13]

lgtm

https://codereview.chromium.org/2204623002/diff/1/base/android/jni_generator/...
File base/android/jni_generator/jni_generator.py (right):

https://codereview.chromium.org/2204623002/diff/1/base/android/jni_generator/...
base/android/jni_generator/jni_generator.py:855: ${REGISTER_NATIVES_SIGNATURE}
__attribute__((unused));
On 2016/08/01 21:42:41, sievers wrote:
> This can only be used on the declaration, not the definition :/

Yeah attributes are annoying :)

[no sievers, 2016-08-02 17:25:00]

The CQ bit was checked by sievers@chromium.org

[commit-bot: I haz the power, 2016-08-02 17:25:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-02 17:30:14]

Description was changed from

==========
Android: Don't require RegisterNatives if there are none

Nowadays the calls up to Java are lazily resolved, so
RegisterNatives() actually does again what the name implies.

Allow not calling RegisterNatives() if there are no native methods
by marking it with the 'unused' attribute.

In follow-up patches all references will be removed so that the
generator can stop emiting the NOP functions where there are no
native methods.

This makes it more straightforward to design one-way JNI interfaces.

BUG=603936, 617313, 617324
==========

to

==========
Android: Don't require RegisterNatives if there are none

Nowadays the calls up to Java are lazily resolved, so
RegisterNatives() actually does again what the name implies.

Allow not calling RegisterNatives() if there are no native methods
by marking it with the 'unused' attribute.

In follow-up patches all references will be removed so that the
generator can stop emiting the NOP functions where there are no
native methods.

This makes it more straightforward to design one-way JNI interfaces.

BUG=603936, 617313, 617324
==========

[commit-bot: I haz the power, 2016-08-02 17:30:15]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-02 17:33:36]

Description was changed from

==========
Android: Don't require RegisterNatives if there are none

Nowadays the calls up to Java are lazily resolved, so
RegisterNatives() actually does again what the name implies.

Allow not calling RegisterNatives() if there are no native methods
by marking it with the 'unused' attribute.

In follow-up patches all references will be removed so that the
generator can stop emiting the NOP functions where there are no
native methods.

This makes it more straightforward to design one-way JNI interfaces.

BUG=603936, 617313, 617324
==========

to

==========
Android: Don't require RegisterNatives if there are none

Nowadays the calls up to Java are lazily resolved, so
RegisterNatives() actually does again what the name implies.

Allow not calling RegisterNatives() if there are no native methods
by marking it with the 'unused' attribute.

In follow-up patches all references will be removed so that the
generator can stop emiting the NOP functions where there are no
native methods.

This makes it more straightforward to design one-way JNI interfaces.

BUG=603936, 617313, 617324

Committed: https://crrev.com/dbed3229058fc046539cd20cc546a740179d1fc4
Cr-Commit-Position: refs/heads/master@{#409221}
==========

[commit-bot: I haz the power, 2016-08-02 17:33:36]

Patchset 1 (id:??) landed as
https://crrev.com/dbed3229058fc046539cd20cc546a740179d1fc4
Cr-Commit-Position: refs/heads/master@{#409221}