Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2202793002: base: Remove unneeded RegisterNatives() calls on Android (Closed)

Created:
4 years, 4 months ago by no sievers
Modified:
4 years, 4 months ago
Reviewers:
Torne
CC:
chromium-reviews, Dirk Pranke, cbentzel+watch_chromium.org, anandc+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, jam, gcasto+watch-blimp_chromium.org, nyquist+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, jessicag+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, lethalantidote+watch-blimp_chromium.org, darin-cc_chromium.org, dtrainor+watch-blimp_chromium.org, shaktisahu+watch-blimp_chromium.org, khushalsagar+watch-blimp_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@jnireg2
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

base: Remove unneeded RegisterNatives() calls on Android BUG=603936 TBR=danakj@chromium.org Committed: https://crrev.com/a056430f8f7969461abc089f6130a4a89f73d1e9 Cr-Commit-Position: refs/heads/master@{#409281}

Patch Set 1 #

Patch Set 2 : base: Remove unneeded RegisterNatives() calls on Android #

Patch Set 3 : base: Remove unneeded RegisterNatives() calls on Android #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -170 lines) Patch
M base/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M base/android/apk_assets.h View 1 chunk +0 lines, -2 lines 0 comments Download
M base/android/apk_assets.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M base/android/base_jni_registrar.cc View 1 2 3 2 chunks +0 lines, -22 lines 0 comments Download
M base/android/build_info.h View 1 chunk +0 lines, -2 lines 0 comments Download
M base/android/build_info.cc View 1 2 3 1 chunk +0 lines, -5 lines 0 comments Download
M base/android/callback_android.h View 1 chunk +0 lines, -3 lines 0 comments Download
M base/android/callback_android.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M base/android/content_uri_utils.h View 1 chunk +0 lines, -2 lines 0 comments Download
M base/android/content_uri_utils.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M base/android/event_log.h View 1 chunk +0 lines, -2 lines 0 comments Download
M base/android/event_log.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M base/android/java_runtime.h View 1 chunk +0 lines, -3 lines 0 comments Download
M base/android/java_runtime.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M base/android/jni_utils.h View 1 chunk +0 lines, -2 lines 0 comments Download
M base/android/jni_utils.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M base/android/locale_utils.h View 1 chunk +0 lines, -2 lines 0 comments Download
M base/android/locale_utils.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M base/android/path_utils.h View 1 chunk +0 lines, -2 lines 0 comments Download
M base/android/path_utils.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M base/android/sys_utils.h View 1 chunk +0 lines, -2 lines 0 comments Download
M base/android/sys_utils.cc View 2 chunks +1 line, -5 lines 0 comments Download
D base/android/thread_utils.h View 1 1 chunk +0 lines, -16 lines 0 comments Download
M base/base.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M base/test/run_all_unittests.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M base/test/test_file_util.h View 1 2 3 1 chunk +0 lines, -3 lines 0 comments Download
M base/test/test_file_util_android.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M base/test/test_ui_thread_android.h View 1 chunk +0 lines, -1 line 0 comments Download
M base/test/test_ui_thread_android.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M base/threading/platform_thread_android.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M blimp/test/run_all_unittests.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M content/test/run_all_unittests.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M ipc/run_all_unittests.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M net/test/run_all_unittests.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M url/run_all_unittests.cc View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 28 (22 generated)
Torne
LGTM
4 years, 4 months ago (2016-08-02 12:29:26 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2202793002/40001
4 years, 4 months ago (2016-08-02 17:40:06 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/229387)
4 years, 4 months ago (2016-08-02 17:48:35 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2202793002/60001
4 years, 4 months ago (2016-08-02 19:40:21 UTC) #24
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 4 months ago (2016-08-02 19:45:37 UTC) #26
commit-bot: I haz the power
4 years, 4 months ago (2016-08-02 19:47:42 UTC) #28
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/a056430f8f7969461abc089f6130a4a89f73d1e9
Cr-Commit-Position: refs/heads/master@{#409281}

Powered by Google App Engine
This is Rietveld 408576698